Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Rating component inline styles #4929

Open
epetrow opened this issue Mar 19, 2024 · 0 comments
Open

Extract Rating component inline styles #4929

epetrow opened this issue Mar 19, 2024 · 0 comments
Labels
Enhancement New feature of an existing functionality or an improvement of an existing functionality.

Comments

@epetrow
Copy link
Contributor

epetrow commented Mar 19, 2024

Is your feature request related to a problem? Please describe.

In the current rendering of the Rating component, namely in the half percision scenario we use inline styles in order to maintain the width and height of the rating item.

<span class="k-rating-precision-part" style="clip-path: inset(0px 50% 0px 0px);">
    <span class="k-icon k-svg-icon k-icon-xl k-svg-i-star">...</span>
</span>
<span style="width: 24px; height: 24px; display: block;"></span>

This is a bit ambiguous as it is not entirely clear what the <span> does.

Describe the solution you would like to see implemented

Suggestion to extract the inline styles and apply them through a properly named class.

@epetrow epetrow added the Enhancement New feature of an existing functionality or an improvement of an existing functionality. label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature of an existing functionality or an improvement of an existing functionality.
Projects
None yet
Development

No branches or pull requests

1 participant