Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancies in Outline FillMode between components #4923

Open
epetrow opened this issue Mar 13, 2024 · 0 comments
Open

Discrepancies in Outline FillMode between components #4923

epetrow opened this issue Mar 13, 2024 · 0 comments

Comments

@epetrow
Copy link
Contributor

epetrow commented Mar 13, 2024

Describe the bug

The Design team have flagged a couple of discrepancies in the Outline FillMode between components, namely in background-color.

At the moment we are appying a transparent background-color in the case of the Button, while setting #ffffff for Chip and Badge.

Note these are just the first cases that have been flagged and there might be more

To reproduce

Steps to reproduce the behavior:

  1. Go to any Chip/Badge appearance demo, select Outline fillMode and inspect it in DevTools
  2. Then go to any Button demo and do the same
  3. Observe the difference in the background-color being applied

Expected behavior

Have a unified approach when it comes to Outline fillMode backgroud-color across all components

Affected package (please remove the unneeded items)

  • theme-default
  • theme-bootstrap
  • theme-material
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant