Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive use of !important in Kendo Material Theme's Input Fields #4794

Open
khanamiryan opened this issue Nov 20, 2023 · 0 comments
Open
Labels
Bug Something isn't working

Comments

@khanamiryan
Copy link

khanamiryan commented Nov 20, 2023

Description:
The Kendo Material Theme's input fields (k-input-solid, k-picker-solid) have CSS rules that use !important, making it challenging to override these styles without adding more !important declarations. This practice creates specificity conflicts and complicates the customization process, especially when integrating additional libraries.

.k-input-solid, .k-picker-solid {
    border-bottom-right-radius: 0 !important;
    border-bottom-left-radius: 0 !important;
    border-width: 1px 0;
    border-top-color: transparent !important;
}

And because solid input is default approach of fields, you should or add !important to all overriding, or manually change type of the filed from solid to another.

Steps to Reproduce:

Include the Kendo Material Theme in a project.
Attempt to override styles of .k-input-solid or .k-picker-solid without using !important.
Note the difficulty faced in customizing these elements due to the !important declarations.

Expected Behavior:
The input field styles should be structured in a way that allows for easier customization and overrides without relying on excessive !important declarations, ensuring smoother integration with other libraries and frameworks.

Suggested Solution:
Consider refactoring the CSS rules for .k-input-solid and .k-picker-solid to reduce the usage of !important declarations.

@khanamiryan khanamiryan added the Bug Something isn't working label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant