Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing styles related to table resizing #4770

Open
radkostanev opened this issue Oct 31, 2023 · 0 comments
Open

Missing styles related to table resizing #4770

radkostanev opened this issue Oct 31, 2023 · 0 comments
Labels
Bug Something isn't working C:Editor

Comments

@radkostanev
Copy link
Member

radkostanev commented Oct 31, 2023

Describe the bug
When the Editor component has its edit mode set to 'div', all styles related to table resizing are missing.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://blazorrepl.telerik.com/mnbknPYM43T4JDro14
  2. Select any cell.
  3. Notice resize handles appear but are mispositioned. Also notice that row and column resizing is not possible.
  4. Also notice that the resize handles of the image below the table are correctly positioned and work as expected.

Expected behavior
The table resizing functionality should continue to work despite the edit mode.

Screenshots
image

Affected package (please remove the unneeded items)

  • theme-default
  • theme-bootstrap
  • theme-material
  • theme-tasks

Affected suites (please remove the unneeded items)

  • Kendo UI for jQuery
  • Kendo UI for Angular
  • Kendo UI for React
  • Kendo UI for Vue
  • Telerik UI for Blazor

Affected browsers (please remove the unneeded items)

  • All

Build system information (please remove the unneeded items)

  • Not Applicable

Additional context
Currently we set various styles that are necessary for different operations, such as the following style for image resizing: https://github.com/telerik/kendo-themes/blob/master/packages/fluent/scss/editor/_layout.scss#L58-L61

However, we have not provided any styles necessary for table resizing. To be exact, the following classes should be added to the themes for the above example to work as expected:

CSS that should be added
  .k-editor-resize-wrap-element {
    display: inline-block;
    position: relative;
  }

  .ProseMirror.resize-cursor {
    cursor: ew-resize;
    cursor: col-resize;
  }

  .ProseMirror.resize-cursor-vertical {
    cursor: sn-resize;
    cursor: row-resize;
  }

  .ProseMirror .column-resize-handle {
    position: absolute;
    right: -2px; top: 0; bottom: 0;
    width: 4px;
    z-index: 20;
    background-color: #adf;
    pointer-events: none;
  }

  .ProseMirror .row-resize-handle {
    position: absolute;
    right: 0; left: 0; bottom: 0;
    transform: translate(0, 50%);
    height: 4px;
    z-index: 20;
    background-color: #adf;
    pointer-events: none;
  }

Here is a REPL link with the above-mentioned styles and the final result: https://blazorrepl.telerik.com/QxbEdbas477u1pfT53

Lastly, note the above may not be a full list of styles that are missing in 'div' mode, rather than are just the styles we need for resizing to work.

@radkostanev radkostanev added Bug Something isn't working C:Editor labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working C:Editor
Projects
None yet
Development

No branches or pull requests

1 participant