Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issues with RadDataGrid #466

Open
mrlacey opened this issue Jul 24, 2020 · 3 comments
Open

Accessibility issues with RadDataGrid #466

mrlacey opened this issue Jul 24, 2020 · 3 comments

Comments

@mrlacey
Copy link

mrlacey commented Jul 24, 2020

Description

RadDataGrid contains multiple accessibility issues.

Steps to Reproduce

  1. Create a UWP app with Windows Template Studio
  2. Add the TelerikDataGrid page.
  3. Run the generated app
  4. Analyze with Accessibility Insights for Windows

Expected Behavior

The control should be fully accessible and pass the basic checks, especially the ones that relate to Section 508

Additionally, it should be possible to navigate the content of the grid with Narrator and access all content.
Narrator should also include meaningful names for the elements that can be focused.

Actual Behavior

Accessibility Insights reports that:

  • The control does not support the Grid pattern for accessible controls.
  • The control does not support the Table pattern for accessible controls.
  • Onscreen elements to do provide a BoundingRectangle
  • Internal to the control, there is an unnamed progressbar that can receive focus.

When using Narrator:

  • Only the contents of the first column are read aloud.
  • An unhelpful description is provided for the panel where column headers can be dragged for grouping.

It seems the issues dismissed in #457 were never addressed.

Basic Information

  • Version with issue: 1.0.1.9
  • Last known good version: n/a
  • IDE: VS 16.6.4
  • UWP SDK: 18362-19041
  • Nuget Packages: 1.0.1.9

Screenshots

image

image

Reproduction Link

@APopatanasov
Copy link
Collaborator

Hi @mrlacey ,

We agree that the accessibility of the DataGrid control could further be improved. #457 was closed because the described issue was tested against an example that uses a very old version of the controls where the DataGrid's accessibility was not even implemented.

I am a little bit confused by the results of the Accessibility Insights tool because the DataGrid implements both the Grid and Table patters. The error is about the DataGridContentLayer that should not support it - I believe the error comes from the GetAutomationControlType core that returns a wrong type for the content layer.

About the Narrator I have tested the control using it and on selection of a cell the content of the cell was read aloud as expected - there are some issues when Tab navigation is used and there we can improve the control. The accessibility of the grouping could be improved as well.

@mrlacey
Copy link
Author

mrlacey commented Jul 28, 2020

When I try and use Narrator, I can't navigate to anything other than the first column.

Using this XAML (if it makes a difference).

<tg:RadDataGrid ColumnDataOperationsMode="Flyout" x:Name="grid" ItemsSource="{x:Bind Source, Mode=OneWay}" AutoGenerateColumns="False" >
    <tg:RadDataGrid.Columns>
        <tg:DataGridTextColumn PropertyName="OrderID" />
        <tg:DataGridDateColumn PropertyName="OrderDate" />
        <tg:DataGridTextColumn PropertyName="Company" />
        <tg:DataGridTextColumn PropertyName="ShipTo" />
        <tg:DataGridNumericalColumn PropertyName="OrderTotal" />
        <tg:DataGridTextColumn PropertyName="Status" />
        <tg:DataGridTemplateColumn Header="Symbol">
            <tg:DataGridTemplateColumn.CellContentTemplate>
                <DataTemplate x:DataType="model:SampleOrder">
                    <FontIcon
                            HorizontalAlignment="Left"
                            Margin="{StaticResource MediumLeftRightMargin}"
                            FontFamily="{ThemeResource SymbolThemeFontFamily}"
                            Glyph="{x:Bind Symbol}" />
                </DataTemplate>
            </tg:DataGridTemplateColumn.CellContentTemplate>
        </tg:DataGridTemplateColumn>
    </tg:RadDataGrid.Columns>
</tg:RadDataGrid>

@APopatanasov
Copy link
Collaborator

The provided code snippet looks good to me. I have tested the examples that are part of our SDKExamples application with the narrator and there the Cells are read as expected when they are selected using the mouse - if you are using the Tab for selection/navigation an issue will be observed as explained above (this is the area of the DataGrid that could be improved).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants