Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow code suggestions in Telegraf 4.16.X after update #1967

Open
UMember opened this issue Mar 9, 2024 · 8 comments
Open

Slow code suggestions in Telegraf 4.16.X after update #1967

UMember opened this issue Mar 9, 2024 · 8 comments

Comments

@UMember
Copy link

UMember commented Mar 9, 2024

Issue: After updating Telegraf to version 4.16.X in VS Code, there is a noticeable slowdown in code suggestions. This issue was not present in version 4.15.3.

Steps to reproduce:

  1. Update Telegraf to version 4.16.X in VS Code.
  2. Observe the delay in code suggestions.
  3. Downgrade to version 4.15.3.
  4. Notice that code suggestions work normally with version 4.15.3.
4.14.0.mp4
4.16.3.mp4

Expected behavior: Code suggestions should be as responsive as they were in version 4.15.3.

Additional information: Other users have reported similar issues after updating Telegraf. Some improvements were observed by disabling certain settings in tsserver LSP, but the problem persists.

Versions:

  • VS Code: 1.87.1 / 1.85 / 1.86
  • Node js: 21.7.1 / 21.5.0
  • Telegraf: 4.16.X (affected), 4.15.3 (not affected)
  • Operating System: Windows

Possible solution: Investigate potential compatibility issues with extensions or configurations in tsserver LSP that may be causing the slowdown.

Note: Any help or insights to resolve this issue would be greatly appreciated. Thank you!

@awerc
Copy link

awerc commented Mar 9, 2024

Also getting this issue, tsc execution time for whole project increased from 3sec to 14sec after telegraf upgrade. Its almost impossible to work with such slow code suggestions and typescript annotations

@MKRhere
Copy link
Member

MKRhere commented Mar 9, 2024

Have you tried setting "skipLibCheck": true in tsconfig.json?

@awerc
Copy link

awerc commented Mar 9, 2024

Yes, its with "skipLibCheck": true

@UMember
Copy link
Author

UMember commented Mar 9, 2024

It didn't affect me either

Have you tried setting "skipLibCheck": true in tsconfig.json?
Yes, its with "skipLibCheck": true

@imdkbj
Copy link
Contributor

imdkbj commented Apr 1, 2024

I am also facing the same even with previous version too. Even suggestion for local files taking too much time. Just remove the telegraf and see how fast is this. Again add and u will find the slowness. I have just checked the github codespace and found the same issue, Do we have any way to debug this.

@KoshkenS3
Copy link

me too

@t7yang
Copy link

t7yang commented Apr 27, 2024

I tested it locally with npm link and git bisect, here is the problem commit:

8061d43533d6751a9cf603dd50b64138882f4120 is the first bad commit
commit 8061d43533d6751a9cf603dd50b64138882f4120
Author: Muthu Kumar <muthukumar@thefeathers.in>
Date:   Tue Feb 20 20:52:31 2024 +0530

    fix: GetMsg type

 src/context.ts | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

@MKRhere
Copy link
Member

MKRhere commented Apr 27, 2024

I see; thanks @t7yang! GetMsg provides accurate types for ctx.msg. I'll have to think about whether it's optimisable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants