createWebhook always respond 404 with Koa

[mahnunchik]

Context

• Telegraf.js Version: 4.14.0
• Node.js Version: v18.17.1
• Operating System: macOS

Minimal Example Code Reproducing the Issue

import Koa from 'koa';
const app = new Koa();
const bot = new Telegraf(token);

const webhook = await bot.createWebhook({ domain });
app.use((ctx, next) => {
  return webhook(ctx.request, ctx.response, next);
});

Expected Behavior

200 status code

Current Behavior

404 status code

Error Message and Logs (export DEBUG='telegraf:*')

No errors in debug log

[hypernova7]

Try with this example: https://github.com/feathers-studio/telegraf-docs/blob/master/examples/webhook/koa.ts

[mahnunchik]

@hypernova7 example is completely broken.

app.use(async (ctx, next) =>
	(await bot.createWebhook({ domain: webhookDomain }))(ctx.req, ctx.res, next),
);

1. Creates webhook on each request
2. Doesn't handle updates
3. Responds with 404

[MKRhere]

The original code posted above seems fine. It can only respond 404 if for whatever reason webhook calls next, which means it is not going to handle the request. I'll test and update the example.

[mahnunchik]

No, I've tested on koa 2.14.2

Handler called and server responds webhook with right body but 404 status.

[hypernova7]

Try with bot.launch

import 'dotenv/config'
import Koa from 'koa'
import ngrok from 'ngrok';
import { Telegraf } from 'telegraf'


const app = new Koa();
const bot = new Telegraf(process.env.BOT_TOKEN);
const url = await ngrok.connect(8080); // for development


bot.start((ctx) => {
  ctx.reply('Hi')
})

bot.launch({
  webhook: {
    domain: url,
    port: 8080,
    cb: app
  }
})

[mahnunchik]

koa integration is still broken

Error [ERR_HTTP_HEADERS_SENT]: Cannot write headers after they are sent to the client

[mahnunchik]

@MKRhere

The original code posted above seems fine.

The original code creates webhook on each request. But the main problem is that it doesn't work

[mahnunchik]

ctx.res
Node's response object.
Bypassing Koa's response handling is not supported. Avoid using the following node properties:
res.statusCode
res.writeHead()
res.write()
res.end()

https://koajs.com/#ctx-res

[mahnunchik]

// create webhook only ONCE
const webhook = await bot.createWebhook({ domain: webhookDomain });
app.use(async (ctx, next) => {
  // use ctx.request to have access to body
  await webhook(ctx.request, ctx.res, next);
});

But still it responds 404...