Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#EXT-X-ENDLIST is not added as a tag to the parsed m3u object #8

Open
oferh opened this issue May 4, 2015 · 3 comments
Open

#EXT-X-ENDLIST is not added as a tag to the parsed m3u object #8

oferh opened this issue May 4, 2015 · 3 comments

Comments

@oferh
Copy link

oferh commented May 4, 2015

The parser ends the parsing when it finds a #EXT-X-ENDLIST tag but doesn't add it to the tags.

@mkozjak
Copy link

mkozjak commented Dec 16, 2015

This is actually not an issue.

A type needs to be set:

parser.on('m3u', function(m3u) {
  m3u.set('playlistType', 'VOD')
})

#EXT-X-ENDLIST will then be appended correctly.

https://github.com/tedconf/node-m3u8/blob/master/test/m3u.test.js#L189

@oferh
Copy link
Author

oferh commented Dec 17, 2015

it's a workaround but according to the spec 6.3.4 in the draft an EVENT playlist may also have EXT-X-ENDLIST tag

@akhoury
Copy link

akhoury commented Feb 25, 2016

I agree with @oferh.

EXT-X-PLAYLIST-TYPE is optional.

https://tools.ietf.org/html/draft-pantos-http-live-streaming-07#section-3.3.7

The EXT-X-PLAYLIST-TYPE tag provides mutability information about the Playlist file. It applies to the entire Playlist file. It is optional.

if this PR #16 gets merged, it will take care of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants