New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleting used build config results in non-editable webhook #242
Comments
I suspect the same will happen when editing a webhook via the REST api (which is how it works on a project edit page) |
I have a fix that looks like it works. I need to get the coverage up on this code, but will try to push later today or tomorrow. |
BTW, I found another bug. Copying a project that contains webhooks with specific builds configured does not update those WebHooks with the new buildType ids in the new project. |
So it looks like copying a project fires off the If a project is new, then it won't have webhooks configured. However, if it has some configured AND any webhook specifically references a Since I have the old edit: Name might not be unique in a project, so using |
it's the gift that keeps on giving :wry-smile: |
New commit pushed. It will build soon. No coverage improvements yet, but now has support for deleted builds. |
Finally got a chance to do some testing on this... On first try I got a 404 trying to edit the webhook, which I couldn't repro, which was annoying. I cleared out the logs (to get rid of the noise), then restarted the server, then tried again, noting down what I did as I went:
I think 14 is related to the 10 second delay (if that's still in there), but not sure what's the go with 16. I reckon we're at "usable", but there's still some gremlins in there. |
I found another event that might help. With regards to 16, I have not written that part yet. The last couple of weeks have been crazy busy. |
I know that feeling all too well :) |
Expected Behavior
A webhook configured to point to deleted build config should be able to be loaded.
Current Behavior
We get an error
Steps to Reproduce (for bugs)
Project1
BuildConfigA
andBuildConfigB
Project1
, that only triggers onBuildConfigB
project-config.xml
shows that the id is stored in thebuild-types
BuildConfigB
/admin/admin.html?item=tcWebHooks
)n
WebHooks configured in this TeamCity Server" linkEdit project Webhooks
forProject1
edit
for the webhook created in step 3-> get failure popup
An unexpected error occured. Please see your browser's javascript console.
Console log has:
with an stack trace of:
Your Environment
The text was updated successfully, but these errors were encountered: