Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password field is in plan text #227

Open
alwaysharsha opened this issue Sep 27, 2023 · 2 comments
Open

Password field is in plan text #227

alwaysharsha opened this issue Sep 27, 2023 · 2 comments

Comments

@alwaysharsha
Copy link

Expected Behavior

Password field shouldn't be exposed in plain text

Current Behavior

Currently, the password field is in plain text
image

Steps to Reproduce (for bugs)

Refer screen above when providing the credentials in basic it is capturing the credentials in plain text

Your Environment

  • tcWebHooks Version: 1.2.2
  • TeamCity Version: 2023.5.3
  • TeamCity server Operating System: Windows Server 2016
  • Are you using a WebHook Template?: Yes

Example Configuration (xml)

@netwolfuk
Copy link
Member

Hi @alwaysharsha

The best option is to use a WebHook Parameter set as "password". TeamCity will store it outside your build settings in an encrypted file.

Then reference the WebHook Parameter in the password field of your webhook authentication settings.

See this page for more information: https://github.com/tcplugins/tcWebHooks/wiki/Hiding-Sensitive-Values-In-WebHook-Configuration

Here is an example I have on my test server...

image

And then referenced in a webhook
image

@netwolfuk
Copy link
Member

netwolfuk commented Sep 27, 2023

BTW, the webhook configuration is stored on the teamcity server un-encrypted (I can't change how that works). So any implied security by using a hidden field in the webhook edit dialog would be mis-leading. That is why is it a plain text box, so that it's obvious that it won't be stored securely.

Referencing a secure WebHook Parameter is the better option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants