Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_sound method to support playing chimes from motion and ding #28

Open
tchellomello opened this issue Mar 15, 2017 · 3 comments
Open

Fix test_sound method to support playing chimes from motion and ding #28

tchellomello opened this issue Mar 15, 2017 · 3 comments
Labels
bug enhancement help-wanted

Comments

@tchellomello
Copy link
Owner

tchellomello commented Mar 15, 2017 •
edited

Fix test_sound method to support playing chimes from motion and ding

https://github.com/tchellomello/python-ring-doorbell/blob/master/ring_doorbell/__init__.py#L391-L396
@tchellomello tchellomello modified the milestones: v.1.1.2, v.1.1.3 Mar 15, 2017
@tchellomello tchellomello modified the milestones: v.1.1.4, v.1.1.3 Mar 31, 2017
@vickyg3
Copy link
Collaborator

vickyg3 commented Sep 15, 2017

hi, any idea on what needs to be done to get this working? i'd be happy to contribute code. is the only way to find out what parameters need to be passed is to reverse engineer what my phone does in the ring app when playing the test_sound?

@tchellomello
Copy link
Owner Author

Hello @vickyg3, I think you can try to use the mitmproxy on your phone to see how that interact with your phone.
Please let me know if you need any assistance.

vickyg3 added a commit to vickyg3/python-ring-doorbell that referenced this issue Sep 20, 2017
@vickyg3
chime: Support playing motion test sound
a22a380 
Changes the test_sound property to be a function. Fixes Issue tchellomello#28.
@vickyg3 vickyg3 mentioned this issue Sep 20, 2017
Merged
tchellomello pushed a commit that referenced this issue Sep 23, 2017
@vickyg3 @tchellomello
chime: Support playing motion test sound (#46)
fb8edf6 
Changes the test_sound property to be a function. Fixes Issue #28.
@tchellomello tchellomello modified the milestones: v.0.1.5, v.0.1.6, v.0.1.7 Oct 17, 2017
@tchellomello tchellomello modified the milestones: v.0.1.7, v.0.1.8, v.0.1.9 Nov 22, 2017
@tchellomello tchellomello removed this from the v.0.1.9 milestone Nov 29, 2017
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this issue recently. This issue has been automatically marked as stale because of that. It will be closed if no further activity occurs.
Please make sure to update to the latest ring_doorbell version and check if that solves the issue.
Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs and Issues label Apr 18, 2024
@sdb9696 sdb9696 removed the stale Stale PRs and Issues label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement help-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vickyg3 @tchellomello @sdb9696