[WIP] Ring Alarm support #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @samskalicky. I've recently been added as a maintainer for this library. This PR is quite old and by itself does not appear to add functionality beyond identifying a base station. I'm going to convert it to Draft and you can let me know if you (or anyone else) wants to do further work on it together. |
|
Closing due to lack of activity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for Ring Alarm base stations. Fixes #250. Based on the work in https://github.com/dgreif/ring
Hello community! Im new to python-ring-doorbell and Ring in general. I would like to help add support for Ring Alarm base stations. Please help me get started, any pointers or suggestions would be greatly appreciated!
So far im following the code in https://github.com/dgreif/ring/blob/9d63e2864960b6746912325492ee3bb642b39127/api/api.ts#L71 and looking at the json that gets returned in the query: https://github.com/tchellomello/python-ring-doorbell/blob/master/ring_doorbell/__init__.py#L73
Ive made a few changes to get started. but kinda poking around in the dark.