Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'AsyncArrowFunction' test #4045

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove 'AsyncArrowFunction' test #4045

wants to merge 1 commit into from

Conversation

linusg
Copy link
Member

@linusg linusg commented Apr 8, 2024 •
edited by nicolo-ribaudo

Fixes #4044

@linusg
Remove 'AsyncArrowFunction' test
6d6b370 
There is no such hidden constructor, it's the same as the hidden
AsyncFunction constructor. In other words:

```js
Object.getPrototypeOf(async () => {}).constructor ===
Object.getPrototypeOf(async function () {}).constructor
```

Closes tc39#4044.
@linusg linusg requested a review from a team as a code owner April 8, 2024 17:16
@ljharb ljharb requested a review from a team April 8, 2024 17:55
Ms2ger
Ms2ger requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure there is a test that Object.getPrototypeOf(async () => {}) and Object.getPrototypeOf(async function () {}) match.

@nicolo-ribaudo
Copy link
Member

There is an implementation-contributed one at

test262/implementation-contributed/v8/mjsunit/es8/async-await-basic.js

Lines 82 to 93 in 6c60904

// Let functionPrototype be the intrinsic object %AsyncFunctionPrototype%.
async function asyncFunctionForProto() {}
assertEquals(AsyncFunction.prototype,
Object.getPrototypeOf(asyncFunctionForProto));
assertEquals(AsyncFunction.prototype,
Object.getPrototypeOf(async function() {}));
assertEquals(AsyncFunction.prototype, Object.getPrototypeOf(async () => {}));
assertEquals(AsyncFunction.prototype,
Object.getPrototypeOf({ async method() {} }.method));
assertEquals(AsyncFunction.prototype, Object.getPrototypeOf(AsyncFunction()));
assertEquals(AsyncFunction.prototype,
Object.getPrototypeOf(new AsyncFunction()));

@ptomato
Copy link
Contributor

ptomato commented Apr 9, 2024

This ties into something else I've been trying to figure out; do implementations actually execute those implementation-contributed tests?

@anba
Copy link
Contributor

anba commented Apr 9, 2024

[...] do implementations actually execute those implementation-contributed tests?

No, because the tests contain implementation internal functions and syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger requested changes

@ljharb ljharb ljharb approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove non-existend "AsyncArrowFunction" constructor
6 participants
@linusg @nicolo-ribaudo @ptomato @anba @ljharb @Ms2ger