Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test gap for invalid string calendar IDs #3896

Open
justingrant opened this issue Aug 14, 2023 · 0 comments
Open

Test gap for invalid string calendar IDs #3896

justingrant opened this issue Aug 14, 2023 · 0 comments

Comments

@justingrant
Copy link
Contributor

Codecov found that there's no test coverage for invalid calendar string IDs, e.g. "notacal" in the following AOs:

  • ToRelativeTemporalObject
  • ToTemporalMonthDay
  • ToTemporalYearMonth
  • ToTemporalZonedDateTime

These AOs are used in a lot of places, so I'm not sure which test files need to be changed or added (likely 100s of them), but here's a few code samples as a starting point:

Temporal.Duration.from('P1M').add({months: 2}, {relativeTo: "2020-01-01[u-ca=notacal]"} );
Temporal.PlainMonthDay.from("2020-01-01[u-ca=notacal]");
Temporal.PlainYearMonth.from("2020-01-01[u-ca=notacal]");
Temporal.ZonedDateTime.from("2020-01-01[UTC][u-ca=notacal]");
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant