Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporal: reorganize calendar and time zone "wrong type" tests #3873

Open
ptomato opened this issue Jul 18, 2023 · 0 comments
Open

Temporal: reorganize calendar and time zone "wrong type" tests #3873

ptomato opened this issue Jul 18, 2023 · 0 comments

Comments

@ptomato
Copy link
Contributor

ptomato commented Jul 18, 2023 •
edited

From #3847:

I'd fold the calendar-number tests into calendar-wrong-type since there is no longer any special behaviour of numbers to be tested; and I'd split the string tests out of calendar-wrong-type into something like calendar-invalid-iso-string because that now throws a different error.

Originally posted by @ptomato in #3847 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ptomato