Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use early errors to simplify ISO 8601 grammar #1984

Open
ptomato opened this issue Dec 17, 2021 · 0 comments · May be fixed by #2766
Open

Use early errors to simplify ISO 8601 grammar #1984

ptomato opened this issue Dec 17, 2021 · 0 comments · May be fixed by #2766
Assignees
@ptomato
Labels
editorial has-consensus iso8601-grammar ISO 8061 grammar spec-text Specification text involved
Milestone
Stage "3.5"

Comments

@ptomato
Copy link
Collaborator

ptomato commented Dec 17, 2021

Follow up from #1952 (comment)

Use early errors in the ISO 8601 grammar to avoid having to create such bizarre productions like TimeHourNotThirtyOneDayMonth, etc. This is an editorial change.

cc @gibson042
@ptomato ptomato added spec-text Specification text involved editorial labels Dec 17, 2021
@ptomato ptomato mentioned this issue Dec 17, 2021
Merged
@ptomato ptomato mentioned this issue Jan 11, 2022
Merged
@ptomato ptomato mentioned this issue Feb 4, 2022
Merged
@gibson042 gibson042 mentioned this issue Jul 1, 2022
Merged
@ptomato ptomato added the iso8601-grammar ISO 8061 grammar label Aug 11, 2022
@ptomato ptomato modified the milestones: Stage 4, Stage "3.5" Dec 8, 2022
@ptomato ptomato mentioned this issue Jul 13, 2023
Open
75 tasks
@ptomato ptomato self-assigned this Jan 19, 2024
ptomato added a commit that referenced this issue Feb 2, 2024
@ptomato
Editorial: Use early errors to simplify time-only grammar
067671d 
Previously the grammar relied on bizarre one-off productions such as
TimeSpecWithOptionalOffsetNotAmbiguous and DateMonthWithThirtyOneDays, to
prevent time strings such as 0119 (01:19 but ambiguous with 19th January)
or 1524-08 (15:24 at -08:00 from UTC, but ambiguous with August of 1524)
from parsing correctly without a time designator.

By using early errors, these confusing productions are no longer necessary
to achieve the desired result.

Closes: #1984
@ptomato ptomato linked a pull request Feb 2, 2024 that will close this issue
Open
ptomato added a commit that referenced this issue Apr 30, 2024
@ptomato
Editorial: Use early errors to simplify time-only grammar
3457d35 
Previously the grammar relied on bizarre one-off productions such as
TimeSpecWithOptionalOffsetNotAmbiguous and DateMonthWithThirtyOneDays, to
prevent time strings such as 0119 (01:19 but ambiguous with 19th January)
or 1524-08 (15:24 at -08:00 from UTC, but ambiguous with August of 1524)
from parsing correctly without a time designator.

By using early errors, these confusing productions are no longer necessary
to achieve the desired result.

Closes: #1984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
editorial has-consensus iso8601-grammar ISO 8061 grammar spec-text Specification text involved
Projects
None yet
Milestone
Stage "3.5"
Development

Successfully merging a pull request may close this issue.

Editorial: Use early errors and parameterization to simplify ISO 8601 grammar tc39/proposal-temporal
1 participant
@ptomato