Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookbook example of custom time zone from tzdata rules #605

Open
ptomato opened this issue May 20, 2020 · 4 comments · May be fixed by #1370
Open

Cookbook example of custom time zone from tzdata rules #605

ptomato opened this issue May 20, 2020 · 4 comments · May be fixed by #1370
Assignees
@ptomato
Labels
documentation Additions to documentation
Milestone
Post Stage 4

Comments

@ptomato
Copy link
Collaborator

ptomato commented May 20, 2020

Follow up from #240, we need a cookbook example that does this:

Construct [a Temporal.TimeZone] object directly from tzdata-compatible rules of arbitrary complexity (e.g., for use in testing).

This requires custom time zone support.
@ryzokuken
Copy link
Member

@ptomato I'm not sure if Etc/TAI fills in this gap, tbh, since I'm just using a helper library for the conversions. What do you think?

@ryzokuken ryzokuken added the documentation Additions to documentation label Jun 10, 2020
@ryzokuken ryzokuken added this to To do in Finalize documentation via automation Jun 10, 2020
@ptomato
Copy link
Collaborator Author

ptomato commented Jun 10, 2020

The request for the example came from @gibson042 but I would guess that the important part is the tzdata-compatible rules? I had some half-finished code for parsing them. Although, I think that TAI should be included in the cookbook regardless.

@ptomato ptomato added this to the Stable proposal milestone Sep 17, 2020
@ptomato ptomato added spec-text Specification text involved non-prod-polyfill THIS POLYFILL IS NOT FOR PRODUCTION USE! and removed non-prod-polyfill THIS POLYFILL IS NOT FOR PRODUCTION USE! spec-text Specification text involved labels Sep 18, 2020
@ptomato
Copy link
Collaborator Author

ptomato commented Oct 19, 2020

Cookbook example to be written after the freeze and before Stage 3

@ptomato ptomato modified the milestones: Stable proposal, Stage 3 Oct 19, 2020
@ptomato ptomato mentioned this issue Oct 22, 2020
Closed
@ptomato
Copy link
Collaborator Author

ptomato commented Jan 13, 2021

On further reflection this isn't a requirement for Stage 3. To be done later.

@ptomato ptomato modified the milestones: Stage 3, Next Jan 13, 2021
@ptomato ptomato removed this from To do in Finalize documentation Jan 13, 2021
@ptomato ptomato self-assigned this Feb 16, 2021
ptomato added a commit that referenced this issue Feb 19, 2021
@ptomato
cookbook: Add "Time zone from tzdata rules" example
adb5a64 
An example of parsing the rules from the tzdata (sometimes called "Olson
database") directly, and creating a Temporal.TimeZone object out of them.

Closes: #605
@ptomato ptomato linked a pull request Feb 19, 2021 that will close this issue
Open
ptomato added a commit that referenced this issue Feb 19, 2021
@ptomato
cookbook: Add "Time zone from tzdata rules" example
8f1d8f2 
An example of parsing the rules from the tzdata (sometimes called "Olson
database") directly, and creating a Temporal.TimeZone object out of them.

Closes: #605
ptomato added a commit that referenced this issue Feb 22, 2021
@ptomato
cookbook: Add "Time zone from tzdata rules" example
4fc9cf5 
An example of parsing the rules from the tzdata (sometimes called "Olson
database") directly, and creating a Temporal.TimeZone object out of them.

Closes: #605
@ptomato ptomato modified the milestones: Next, Post Stage 4 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
documentation Additions to documentation
Projects
None yet
Milestone
Post Stage 4
Development

Successfully merging a pull request may close this issue.

Cookbook example for compiling time zone from tzdata rules tc39/proposal-temporal
2 participants
@ptomato @ryzokuken