Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize type checking in the spec text #41

Open
eemeli opened this issue Jan 18, 2024 · 1 comment
Open

Normalize type checking in the spec text #41

eemeli opened this issue Jan 18, 2024 · 1 comment

Comments

@eemeli
Copy link
Member

eemeli commented Jan 18, 2024

During the review of #39, I got conflicting guidance from @dminor #39 (comment) and @ryzokuken #39 (comment) on whether to do type checking as "x is a String" vs. "Type(x) is String". We should figure out which to use.

@linusg
Copy link
Member

linusg commented Jan 31, 2024

Relevant ecma262 issues/PRs:

(it appears that "x is a String" is preferred in most cases)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants