Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing "no deprecated lang param usage" in etymology templates? #619

Open
digitalheir opened this issue May 8, 2024 · 4 comments
Open

Comments

@digitalheir
Copy link
Contributor

digitalheir commented May 8, 2024

Wiktionary entry for scouse:

{{clipping of|en|lobscouse|dot=,}} of uncertain origin.

Kaikki output:

  "etymology_templates": [
    {
      "args": {
        "1": "Clipping of <span class='form-of-definition-link'><i class=\"Latn mention\" lang=\"en\">lobscouse</i></span>,",
        "lang": ""
      },
      "expansion": "Clipping of lobscouse,",
      "name": "no deprecated lang param usage"
    },
    {
      "args": {
        "1": "en",
        "2": "lobscouse",
        "dot": ","
      },
      "expansion": "Clipping of lobscouse,",
      "name": "clipping of"
    }
  ],

Why does the former exist? "no deprecated lang param usage"? Seems like an internal Wiktionary warning, not very useful to end users I'd say!

@xxyzz
Copy link
Collaborator

xxyzz commented May 8, 2024

Template clipping of uses the no deprecated lang param usage template, the "etymology_templates" field contains all used templates, please see #611 (comment)

@xxyzz
Copy link
Collaborator

xxyzz commented May 9, 2024

A work around was committed in c46cdd8

@myrriad
Copy link

myrriad commented May 9, 2024

Is it expected that "no deprecated lang param usage" is in both "ADDITIONAL_EXPAND_TEMPLATES" and ignored_etymology_templates?

@xxyzz
Copy link
Collaborator

xxyzz commented May 10, 2024

Probably fine. ADDITIONAL_EXPAND_TEMPLATES pre-expands the template and ignored_etymology_templates removes the template from "etymology_templates" list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants