Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

Revisit contribution requirements #170

Open
housseindjirdeh opened this issue Dec 4, 2018 · 1 comment
Open

Revisit contribution requirements #170

housseindjirdeh opened this issue Dec 4, 2018 · 1 comment
Assignees

Comments

@housseindjirdeh
Copy link
Collaborator

housseindjirdeh commented Dec 4, 2018

When we started this project, Lighthouse only gave a score for PWA:

screen shot 2018-12-04 at 9 48 47 am

A lot has changed since, where scores are provided along multiple areas:

screen shot 2018-12-04 at 9 51 11 am

@developit brought this up and made a very good point. There are a few things we can do here:

  • Allow contributions that meet a minimum score for PWA, Performance and Accessibility
  • Allow contributes that meet an average score for PWA, Performance and Accessibility

Updating this will tie in well to updating all scores to LH 3.0 via #60. We also should update how we display the scores on the site (ideally showing all of them)

@housseindjirdeh housseindjirdeh self-assigned this Jan 11, 2019
@jnorthrup
Copy link

jnorthrup commented Apr 26, 2019

actually tbh, I'm under the impression that the lighthouse requirements are turning simple and concise PWA's into steaming piles of last-minute tweaks to bump up a few points here and there, and may cause wanton sloppy rewrites of simple working code.

I have started mentioning this to node developers I work with and that they may get lucky and find informative code in older git revisions of these formula-1 race-day editions.

the case may also be that this is homogenizing the options of the backend and front-end and ruling out entire classes of approach. i have to say these are not the kind of PWA's (style, features, usecases) my customers are interested in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants