Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Use new syntax for init containers #24

Open
cesartl opened this issue Jan 31, 2018 · 1 comment
Open

Use new syntax for init containers #24

cesartl opened this issue Jan 31, 2018 · 1 comment

Comments

@cesartl
Copy link

cesartl commented Jan 31, 2018

From the documentation, it can be read:

1.5 syntax still works on 1.6, but we recommend using 1.6 syntax. In Kubernetes 1.6, Init Containers were made a field in the API. The beta annotation is still respected in 1.6 and 1.7, but is not supported in 1.8 or greater.

Running K8s 1.9.0, I've had problems running k8s-redis-ha which uses the old notation for init containers.

I think it would be better to support the latest version of k8s, perhaps keeping the old one for legacy support

      initContainers:
        - name: k8s-redis-ha-server
          image: tarosky/k8s-redis-ha:server-3.0.1
          volumeMounts:
            - name: opt
              mountPath: /opt

I'm happy to make PR if that helps

@cesartl
Copy link
Author

cesartl commented Jan 31, 2018

Actually just saw there is already a PR for that see #23

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant