Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace standard giphy component with custom one to match UI design #522

Closed
talmahaj opened this issue Jul 31, 2020 · 1 comment
Closed
Assignees

Comments

@talmahaj
Copy link

talmahaj commented Jul 31, 2020

See specs

Requirement Addition:19 August 2020:

  • Standard GIF colored placeholder tiles should be displayed within the carousel and the search screen when GIF's are loading
@nyarian nyarian self-assigned this Aug 13, 2020
nyarian added a commit to nyarian/wallet-android that referenced this issue Aug 18, 2020
Replace Giphy SDK components with custom ones to match the wireframes
nyarian added a commit to nyarian/wallet-android that referenced this issue Aug 18, 2020
Replace Giphy SDK components with custom ones to match the wireframes
nyarian added a commit to nyarian/wallet-android that referenced this issue Aug 19, 2020
Replace Giphy components with custom ones to match the wireframes
nyarian added a commit to nyarian/wallet-android that referenced this issue Aug 19, 2020
Replace Giphy components with custom ones to match the wireframes
nyarian added a commit to nyarian/wallet-android that referenced this issue Aug 19, 2020
Replace Giphy components with custom ones to match the wireframes
nyarian added a commit to nyarian/wallet-android that referenced this issue Aug 20, 2020
Replace Giphy components with custom ones to match the wireframes
nyarian added a commit to nyarian/wallet-android that referenced this issue Aug 26, 2020
Replace Giphy components with custom ones to match the wireframes
@Tas4tari
Copy link

Tas4tari commented Sep 7, 2020

Testing on Huawei P30 Lite, app version 0.4.1:
Requirements:

  • When we originally built the giphy integration in Backup Prompt Modal: Backup Wallet Modal: When user selects Backup Wallet they should be redirected to the Settings screen #501 we decided to release an MVP of the feature using giphy's standard components.
  • However, we want to be able to implement this functionality with the beautiful UI/UX Karim designed in https://app.zeplin.io/project/5dbdf1a40bdfd3832e35c9c5/dashboard?seid=5f16767d5b45918c4c4701d4 which requires us to build a custom component. This should enable the following:
  • Match the UI Karim has designed for both the Add Note screen and the giphy modal: Tested successfully
  • Giphy modal should still slide up to accommodate the keyboard when needed, just like in the standard component: Tested successfully
  • Crop gifs to match rounded corner square in design (think we can try to center the crop horizontally and vertically, and see how good that looks...): Tested successfully
  • Each time screen is loaded, gif carousel should display 20 random gifs from the "money" search query - https://giphy.com/search/money (maybe from the first 100 results, assuming they get less relevant eventually?) Tested successfully
  • Tapping Search Giphy (either the fixed black button, or the last item in the carousel) brings up full-screen search. If possible, display the same 20 random "money" gifs in the same order as in carousel by default, all of which should disappear once user starts entering another search query. : Tested successfully**
  • Tapping outside of the search modal or grabbing drawer should close modal and does not need to preserve search query in case user opens it up again - they can see the default again: Tested successfully
  • Standard GIF colored placeholder tiles should be displayed within the carousel and the search screen when GIF's are loading: Tested successfully

Videos:
Add Note:
https://drive.google.com/file/d/1AoJdCSyJUwgxg8JX5e4VDe0SVs2QiMS8/view?usp=sharing
Colored Tiles:
https://drive.google.com/file/d/122MdfmZb7zTChqM_m9Df7L2I4Qv0NXeC/view?usp=sharing
Search Giphy:
https://drive.google.com/file/d/1lds1tN5IH68fxNPKySUyxdJMUsB1TKoz/view?usp=sharing
Default Gif's:
https://drive.google.com/file/d/1wpEX8lxl5lDYiOxqHf62vHSoR3BRI73U/view?usp=sharing

@Tas4tari Tas4tari closed this as completed Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants