Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need defence-in-depth when streaming new peers #6289

Open
hansieodendaal opened this issue Apr 19, 2024 · 0 comments
Open

Need defence-in-depth when streaming new peers #6289

hansieodendaal opened this issue Apr 19, 2024 · 0 comments

Comments

@hansieodendaal
Copy link
Contributor

hansieodendaal commented Apr 19, 2024 •
edited

This is more defence-in-depth than anything else, closing a potential attack vector. I will remove it, but we should actually ban the peer for offences in UnvalidatedPeerInfo::from_peer_limited_claims as well as providing invalid signatures. What is your opinion?

Originally posted by @hansieodendaal in #6284 (comment)
@AaronFeickert AaronFeickert changed the title Need defence-in-depth when streaming new pears Need defence-in-depth when streaming new peers Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hansieodendaal