Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base node config ban periods are currently set under block sync options. #5933

Open
SWvheerden opened this issue Nov 9, 2023 · 2 comments
Open

Base node config ban periods are currently set under block sync options. #5933

SWvheerden opened this issue Nov 9, 2023 · 2 comments

Comments

@SWvheerden
Copy link
Collaborator

They should move the base node settings as they are not specific to block sync.
@SWvheerden SWvheerden mentioned this issue Nov 9, 2023
Merged
@SWvheerden
Copy link
Collaborator Author

We should probably split the bans into 3 as well:
short, med and long depending on what they are.

SWvheerden added a commit that referenced this issue Nov 13, 2023
@SWvheerden @stringhandler
feat: bans for bad incoming blocks (#5934)
7acc44d 
Description
---
Bans peers who send bad incoming blocks. 
Consolidates banning a bit more. 

Motivation and Context
---
Created an issue to fix the ban period in the config:
#5933

Fixes: #5795

---------

Co-authored-by: stringhandler <mikethetike@tari.com>
@SWvheerden
Copy link
Collaborator Author

dht actor has its own ban configs. These should all be consolidated:

#[derive(Debug, Clone, Copy)]
pub enum OffenceSeverity {
    Low,
    Medium,
    High,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SWvheerden