Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync is broken #788

Open
Cifko opened this issue Nov 24, 2023 · 0 comments
Open

Sync is broken #788

Cifko opened this issue Nov 24, 2023 · 0 comments

Comments

@Cifko
Copy link
Contributor

Cifko commented Nov 24, 2023

We are ignoring the epoch in the SyncRequest.
But the main issue is that when a new epoch starts, the last block send to a new node that the new node has to vote on is from previous epoch. So it will fail validation and the node will go into sleep state.
I think this will be solved once we make the epoch change, but want to write this here, so we don't forget.
To reproduce what's wrong:

  1. In the dan_layer\consensus\src\hotstuff\state_machine\worker.rs change the value of time::sleep to large value. With smaller value it's just flaky.
  2. run the cucumber New validator node registers and syncs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant