Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #196

Open
AaronFeickert opened this issue Aug 16, 2023 · 0 comments · May be fixed by #199
Open

Improve test coverage #196

AaronFeickert opened this issue Aug 16, 2023 · 0 comments · May be fixed by #199

Comments

@AaronFeickert
Copy link
Contributor

Test coverage for this repository should be improved.
This was referenced Aug 16, 2023
Merged
Merged
Draft
SWvheerden added a commit that referenced this issue Aug 21, 2023
@SWvheerden
chore: remove unused rewindable range proof code (#198)
2aa46d0 
Removes old rewindable range proof code that was unused.

Partially addresses #196.
SWvheerden added a commit that referenced this issue Aug 21, 2023
@SWvheerden
feat: simplify zeroizing and add test to DHKE (#197)
1e6f603 
Simplifies the implementation of zeroizing support for Diffie-Hellman
key exchanges and improves test coverage.

Currently, the `DiffieHellmanSharedSecret` struct has manual
implementations of `zeroize` and `drop` to handle zeroizing. Now that we
have a more modern version of `zeroize` as a dependency, we can do
better. This PR uses that crate's `Zeroize` and `ZeroizeOnDrop` derived
traits to handle this more cleanly. It also adds a sanity check that the
byte representations of both sides of a key exchange match, which
improves test coverage.

Partially addresses #196.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: improve test coverage AaronFeickert/tari-crypto
1 participant
@AaronFeickert