Need zoom feature and Download vector graphics from server feature #45

anishkumar11 · 2019-03-05T11:53:10Z

Hi Tarek,

I like your library. I have very useful and powerful. But two features are missing in your library.

Zoom feature. It will help to fill the path tiny places.
If we have put graphic xml file on the server or in the sdcard. then it should be load by your library.

tarek360 · 2019-03-05T11:58:34Z

I like your suggestions, I will be more than happy if you created a pull request for each feature.

On Tue, 5 Mar 2019, 6:53 PM Anish Kumar, ***@***.***> wrote: Hi Tarek, I like your library. I have very useful and powerful. But two features are missing in your library. 1. Zoom feature. It will help to fill the path tiny places. 2. If we have put graphic xml file on the server or in the sdcard. then it should be load by your library. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#45>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIN3WIGL3_dC4UeyV2n6-EvZ0aENMjSWks5vTlqqgaJpZM4bebuE> .

anishkumar11 · 2019-03-06T03:15:58Z

Hi Tarek. I happy you replied about my query.

anishkumar11 · 2019-03-06T03:19:46Z

I have created the pull requests

AmineLAHRIM · 2020-01-29T18:34:34Z

please how about the zoom ?

anishkumar11 · 2020-01-29T18:44:25Z

Zoom functionality like we have in photo library. And we can change path color in zoom mode too.

…

On Thu, Jan 30, 2020, 00:04 Amine LAHRIM ***@***.***> wrote: please how about the zoom ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#45?email_source=notifications&email_token=ACEW7ZZT6MS7PXN3QK6ZZPTRAHK4XA5CNFSM4G3ZXOCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKIIRTQ#issuecomment-579897550>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACEW7Z65QHO6DQ2JMKT3KQLRAHK4XANCNFSM4G3ZXOCA> .

tarek360 · 2020-01-30T04:04:25Z

Hi,
@anishkumar11 where is that pull request?

@AmineLAHRIM could you explain more about your use case?
do you need to zoom at the level of the path or the view?

anishkumar11 · 2020-01-30T04:38:15Z

Yes i need zoon path level too. So we can event this path is clicked in zoom mode. I tried to implement this but fail.

…

On Thu, Jan 30, 2020, 09:34 Ahmed Tarek ***@***.***> wrote: Hi, @anishkumar11 <https://github.com/anishkumar11> where is that pull request? @AmineLAHRIM <https://github.com/AmineLAHRIM> could you explain more about your use case? do you need to zoom at the level of the path or the view? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#45?email_source=notifications&email_token=ACEW7ZY4QDMXFTZ7HHBKCRLRAJGUVA5CNFSM4G3ZXOCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKJTQGQ#issuecomment-580073498>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACEW7ZZOJ5FQ5JH77V2UFV3RAJGUVANCNFSM4G3ZXOCA> .

AmineLAHRIM · 2020-01-30T12:09:35Z

just in view i try with TouchImageView.java and extends from RichPathView the Zoom not working but if the class extends from the SVGImageView that from the library of AndroidSVG it works but the problem that i need to work on your library because of having some great functionality and thank you so much Tarek. for your reply

TouchImageView.java =>
https://gist.github.com/Antarix/65cfc180c05524ce616f

the right problem is in RichPathDrawale because if i make set imageDrawable(A_SIMPLE_DRAWABLE) the zoom work but if I make imageDrawable(richPathDrawable) the zoom didn't work because of extendes methods like draw() ononBoundsChange() ...

but finally we need that richPathDrawable because is part of the library.

anishkumar11 · 2020-01-30T12:24:44Z

Yes correct these problems were arise when i try to modifed your library.

…

On Thu, Jan 30, 2020, 17:45 Amine LAHRIM ***@***.***> wrote: the right problem is in RichPathDrawale because if i make set imageDrawable(A_SIMPLE_DRAWABLE) the zoom work but if I make imageDrawable(richPathDrawable) the zoom didn't work because of extendes methods like draw() ononBoundsChange() ... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#45?email_source=notifications&email_token=ACEW7Z6HTV4GYG4RRYTU7N3RALHGDA5CNFSM4G3ZXOCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKKYUMY#issuecomment-580225587>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACEW7Z7RTORDRJQKWRLR7JDRALHGDANCNFSM4G3ZXOCA> .

anishkumar11 · 2020-01-30T12:26:10Z

sI

…

On Thu, Jan 30, 2020, 09:34 Ahmed Tarek ***@***.***> wrote: Hi, @anishkumar11 <https://github.com/anishkumar11> where is that pull request? @AmineLAHRIM <https://github.com/AmineLAHRIM> could you explain more about your use case? do you need to zoom at the level of the path or the view? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#45?email_source=notifications&email_token=ACEW7ZY4QDMXFTZ7HHBKCRLRAJGUVA5CNFSM4G3ZXOCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKJTQGQ#issuecomment-580073498>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACEW7ZZOJ5FQ5JH77V2UFV3RAJGUVANCNFSM4G3ZXOCA> .

tarek360 · 2020-01-30T12:37:09Z

@AmineLAHRIM cool, you have figured where the problem with a zoom view, are you able to fix that in RichPathDrawabl? What exactly is going wrong in RichPathDrawabl?

AmineLAHRIM · 2020-01-30T13:14:11Z

@tarek360 we cloud not fix it i try so hard about everyday with no result could you please help us

tarek360 · 2020-02-01T02:41:16Z

@AmineLAHRIM I checked it and I found that TouchImageView.java is an ImageView but in your case, you need a ViewGroup, you need a layout to wrap the RichPathView to be able to zoom.

There are many many samples on the internet for zoom layout, I found one of them here

here is an example I tested and the zoom works:

<com.shopgun.android.zoomlayout.ZoomLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    android:id="@+id/touchImageView"
    android:layout_width="match_parent"
    android:layout_height="match_parent">

    <com.richpath.RichPathView
        android:id="@+id/ic_command"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="center"
        app:vector="@drawable/ic_command" />

</com.shopgun.android.zoomlayout.ZoomLayout>

AmineLAHRIM · 2020-02-01T02:56:06Z

Oh my god Thank you for your simple solution that I never think about it.

…

On Sat, Feb 1, 2020, 3:41 AM Ahmed Tarek ***@***.***> wrote: @AmineLAHRIM <https://github.com/AmineLAHRIM> I checked it and I found that TouchImageView.java <https://gist.github.com/Antarix/65cfc180c05524ce616f> is an ImageView but in your case, you need a ViewGroup, you need a layout to wrap the RichPathView to be able to zoom. There are many many samples on the internet for zoom layout, I found one of them here <https://github.com/shopgun/zoomlayout> here is an example I tested and the zoom works: <com.shopgun.android.zoomlayout.ZoomLayout xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto" android:id="@+id/touchImageView" android:layout_width="match_parent" android:layout_height="match_parent"> <com.richpath.RichPathView android:id="@+id/ic_command" android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_gravity="center" ***@***.***/ic_command" /> </com.shopgun.android.zoomlayout.ZoomLayout> [image: zoom] <https://user-images.githubusercontent.com/8615768/73585700-420c1680-44d6-11ea-8fbe-748f0032049a.gif> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#45?email_source=notifications&email_token=AJRGIMBBJ6QCNMO4G7XYAJTRATOM3A5CNFSM4G3ZXOCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKQRPBQ#issuecomment-580982662>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJRGIMAUNSVT32HQU7S6W2TRATOM3ANCNFSM4G3ZXOCA> .

AmineLAHRIM · 2020-02-01T03:32:27Z

but there is a single problem when you zoom you can't apply any click listener effect in RichPathView:
ic_command.setOnPathClickListener(new RichPath.OnPathClickListener() {
@OverRide
public void onClick(RichPath richPath) {
Log.d("TAG", "getFillColor: " + richPath.getFillColor());

                final int random = new Random().nextInt((max - min) + 1) + min;
                RichPathAnimator.animate(richPath)
                        .fillColor(random)
                        .start();
        }
    });

AmineLAHRIM · 2020-02-01T04:41:33Z

i hight recommend to download the zoomlayout source code and edit it like the following instructions:
1/ declare a public richpathview image in ZoomLayout class
2/ relate the richpathview that you have in MainActivity to it like that
zoomLayout.richpathview = richpathview;
3/ edit onTouchEvent
public RichPathView richpathview;
private PointF firstPointerDown = new PointF();
private boolean isImageMoved = false;

@Override
public boolean onTouchEvent(MotionEvent ev) {

    mArray[0] = ev.getX();
    mArray[1] = ev.getY(); 
    PointF curr = new PointF(ev.getX(), ev.getY());

    final int action = ev.getAction() & MotionEvent.ACTION_MASK;
    //final int pointerCount = ev.getPointerCount();

    float deltaXBeforePointerUp;
    float deltaYBeforePointerUp;

    dispatchOnTouch(action, ev);

    switch (action & MotionEvent.ACTION_MASK) {
        case MotionEvent.ACTION_POINTER_DOWN:
            Log.d(TAG, "onTouchEvent: ACTION_POINTER_DOWN DISPATCH");

            break;
        case MotionEvent.ACTION_DOWN:
            Log.d(TAG, "onTouchEvent: ACTION_DOWN DISPATCH");
            firstPointerDown.set(curr);
            Log.d(TAG, "onTouchEvent2: " + curr.x + "  ___ " + firstPointerDown.x);

            break;
        case MotionEvent.ACTION_UP:

            deltaXBeforePointerUp = curr.x - firstPointerDown.x;
            deltaYBeforePointerUp = curr.y - firstPointerDown.y;
            if (Math.abs(deltaXBeforePointerUp) > 0 || Math.abs(deltaYBeforePointerUp) > 0) {
                Log.d(TAG, "onTouchEvent: ACTION_UP NO_DISPATCH");
            } else {
                Log.d(TAG, "onTouchEvent: ACTION_UP DISPATCH");
                if (!isImageMoved) {
                    dispatchEventToRichPathView(ev);
                }
            }

            //init
            isImageMoved=false;
            break;
        case MotionEvent.ACTION_POINTER_UP:
            break;
        case MotionEvent.ACTION_MOVE:
            deltaXBeforePointerUp = curr.x - firstPointerDown.x;
            deltaYBeforePointerUp = curr.y - firstPointerDown.y;
            if (Math.abs(deltaXBeforePointerUp) > 0 || Math.abs(deltaYBeforePointerUp) > 0) {
                Log.d(TAG, "onTouchEvent: ACTION_MOVE NO_DISPATCH");
                isImageMoved=true;
            }
            break;
    }

    scaledPointsToScreenPoints(mArray);
    ev.setLocation(mArray[0], mArray[1]);

    if (!mAllowZoom) {
        return false;
    }


    boolean consumed = mScaleDetector.onTouchEvent(ev);
    consumed = mGestureDetector.onTouchEvent(ev) || consumed;
    if (action == MotionEvent.ACTION_UP) {
        // manually call up
        consumed = mGestureListener.onUp(ev) || consumed;
    }
    return consumed;
}

private void dispatchEventToRichPathView(MotionEvent ev) {
    if (this.richpathview != null) {
        richpathview.dispatchTouchEvent(ev);
    }
}

tarek360 · 2020-02-01T11:26:34Z

So it works now?

AmineLAHRIM · 2020-02-01T12:25:07Z

Yeap with two-finger zoom and one finger drag and one-click coloring.

AmineLAHRIM · 2020-02-01T12:25:33Z

special thanks to you tarek.

tarek360 · 2020-02-01T14:19:11Z

Are you doing a coloring book app?

AmineLAHRIM · 2020-02-01T16:36:59Z

Yes am trying 😃

…

On Sat, Feb 1, 2020, 3:19 PM Ahmed Tarek ***@***.***> wrote: Are you doing a coloring book app? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#45?email_source=notifications&email_token=AJRGIMCONT75JT5A5VDHS6DRAWAGBA5CNFSM4G3ZXOCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKQ6EAA#issuecomment-581034496>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJRGIMG3ZDSSD5D7DVROCJDRAWAGBANCNFSM4G3ZXOCA> .

ManuelCoral1998 · 2020-10-14T15:44:32Z

Remembering what @tarek360 said about the ZoomLayout, I found that this ZoomLayout works fine and allows images to still have their click listener in the RichPathView as long as it has hasClickableChildren set to true.

tarek360 mentioned this issue Jan 30, 2020

please tarek could you add the zoom to the richpath #57

Closed

goforbg mentioned this issue Aug 16, 2020

Add zoom feature. goforbg/ClickableMapView#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Need zoom feature and Download vector graphics from server feature #45

Need zoom feature and Download vector graphics from server feature #45

anishkumar11 commented Mar 5, 2019

tarek360 commented Mar 5, 2019 via email

anishkumar11 commented Mar 6, 2019

anishkumar11 commented Mar 6, 2019

AmineLAHRIM commented Jan 29, 2020

anishkumar11 commented Jan 29, 2020 via email

tarek360 commented Jan 30, 2020

anishkumar11 commented Jan 30, 2020 via email

AmineLAHRIM commented Jan 30, 2020 •

edited

anishkumar11 commented Jan 30, 2020 via email

anishkumar11 commented Jan 30, 2020 via email

tarek360 commented Jan 30, 2020

AmineLAHRIM commented Jan 30, 2020

tarek360 commented Feb 1, 2020

AmineLAHRIM commented Feb 1, 2020 via email •

edited

AmineLAHRIM commented Feb 1, 2020

AmineLAHRIM commented Feb 1, 2020 •

edited

tarek360 commented Feb 1, 2020

AmineLAHRIM commented Feb 1, 2020

AmineLAHRIM commented Feb 1, 2020

tarek360 commented Feb 1, 2020

AmineLAHRIM commented Feb 1, 2020 via email

ManuelCoral1998 commented Oct 14, 2020

Need zoom feature and Download vector graphics from server feature #45

Need zoom feature and Download vector graphics from server feature #45

Comments

anishkumar11 commented Mar 5, 2019

tarek360 commented Mar 5, 2019 via email

anishkumar11 commented Mar 6, 2019

anishkumar11 commented Mar 6, 2019

AmineLAHRIM commented Jan 29, 2020

anishkumar11 commented Jan 29, 2020 via email

tarek360 commented Jan 30, 2020

anishkumar11 commented Jan 30, 2020 via email

AmineLAHRIM commented Jan 30, 2020 • edited

anishkumar11 commented Jan 30, 2020 via email

anishkumar11 commented Jan 30, 2020 via email

tarek360 commented Jan 30, 2020

AmineLAHRIM commented Jan 30, 2020

tarek360 commented Feb 1, 2020

AmineLAHRIM commented Feb 1, 2020 via email • edited

AmineLAHRIM commented Feb 1, 2020

AmineLAHRIM commented Feb 1, 2020 • edited

tarek360 commented Feb 1, 2020

AmineLAHRIM commented Feb 1, 2020

AmineLAHRIM commented Feb 1, 2020

tarek360 commented Feb 1, 2020

AmineLAHRIM commented Feb 1, 2020 via email

ManuelCoral1998 commented Oct 14, 2020

AmineLAHRIM commented Jan 30, 2020 •

edited

AmineLAHRIM commented Feb 1, 2020 via email •

edited

AmineLAHRIM commented Feb 1, 2020 •

edited