test: cover split-brain during promote #9944
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serpentian
force-pushed
the
cover-promote-split-brain
branch
2 times, most recently
from
e6c6a8c
to
a0cdee6
Compare
Gerold103
reviewed
Apr 12, 2024
Comment on lines
99
to
101
| t.helpers.retrying({}, function() | ||
| t.assert_not_equals(g.rs.servers[1]:grep_log('ER_SPLIT_BRAIN'), nil) | ||
| end) |
There was a problem hiding this comment.
Can you instead get it from the info.replication from upstream/downstream status? Log greps is the last resort.
There was a problem hiding this comment.
Sure, it's better to check box.info.replication.upstream
Serpentian
force-pushed
the
cover-promote-split-brain
branch
from
a0cdee6
to
29c2e76
Compare
This test checks, that when PROMOTE from the previous term is encountered we immediately notice split-brain situation and break replication without corrupting data. Closes tarantool#9943 NO_DOC=test NO_CHANGELOG=test
Serpentian
force-pushed
the
cover-promote-split-brain
branch
from
29c2e76
to
71f904d
Compare
There was a problem hiding this comment.
Thanks for the test!
Please consider adding this case to the test/replication-luatest/gh_5295_split_brain_test.lua test. It contains all the similar split-brain test cases. I was sure that the case with an old promote is also handled there, but apparently it's not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test checks, that when PROMOTE from the prevous term is encountered we immediately notice split-brain situation and break replication without corrupting data.
Closes #9943
NO_DOC=test
NO_CHANGELOG=test