json.encode() escapes '/' #6200

vasilky3 · 2021-07-07T17:02:12Z

Приветствую, столкнулся с неожиданным экранированием в json модуле.

localhost:3501> t = {url = "https://srv:7777"}
---
...
localhost:3501> require('json').encode(t)
---
- '{"url":"https:\/\/srv:7777"}'
...

Json.encode экранирует /, по спеке это не обязательно. [rfc4627]

 All Unicode characters may be placed within the
   quotation marks except for the characters that must be escaped:
   quotation mark, reverse solidus, and the control characters (U+0000
   through U+001F).

tarantool/third_party/lua-cjson/lua_cjson.c

Line 135 in 4b2016a

NULL, NULL, NULL, NULL, NULL, NULL, NULL, "\\/",

Ожидаемое поведение:

localhost:3501> t = {url = "https://srv:7777"}
---
...
localhost:3501> require('json').encode(t)
---
- '{"url":"https://srv:7777"}'
...

The text was updated successfully, but these errors were encountered:

vasilky3 · 2021-07-09T10:31:57Z

Up. На стороне клиента также cjson. При decode() экранирование убирается.
Таким образом проблема решилась сама собой.

Totktonada · 2021-07-13T19:04:09Z

Please, share a reason why do you closed the issue if it was intentional. The problem is there.

For unknown reason in upstream lua_cjson slash symbol was escaped while according to the standart [rfc4627] it is unnecessary and is questionably compatible with other implementations. Escapes table fixed and related test added. Fixes tarantool#6200 NO_DOC=bugfix

Totktonada · 2022-03-11T00:56:44Z

A bit more context:

The issue cjson encode table encodes / mpx/lua-cjson#66 in the upstream repository, where the example with an URL (https:// -> https:\/\/) is shown and the author of the library asked for a specific use case, where something breaks due the forward slash escaping.
The pull request Avoid escaping forward slash mpx/lua-cjson#57, where the unconditional fix for the char2escape table is proposed and a discussion appears. Interesting points:
- The author asked again for specific cases, which are broken by the forward slash escaping.
- Aside of the URL example, a token example was provided.
- However I don't see a self-contained / full scenario, where something becomes broken. Quite interesting. I also can't propose one.
There is another pull request Provide a global option to enable/disable escaping of forward slashes mpx/lua-cjson#76, which implements a global option to choose whether to escape a forward slash, but the author asked to lower this option to cjson.new() (IOW, to make it encoder instance specific). I guess the reason is to don't introduce too many global options.
OpenResty's cjson fork has a global option for that: https://github.com/openresty/lua-cjson/#encode_escape_forward_slash (it is introduced in Add configuration option to disable forward slash escaping openresty/lua-cjson#62).

What is also interesting: does anyone verify the char2escape table to spot all cases, where it escapes symbols that are optional for escape? Are there other such cases?

This issue also let me summarize some thoughts on backward compabilility mechanisms: #6912.

For unknown reason in upstream lua_cjson slash symbol was escaped while according to the standart [rfc4627] it is unnecessary and is questionably compatible with other implementations. Escapes table fixed and related test added. Fixes tarantool#6200 NO_DOC=bugfix

For unknown reason in upstream lua_cjson slash symbol was escaped while according to the standard [rfc4627] it is unnecessary and is questionably compatible with other implementations. Escapes table fixed and related test added. Fixes tarantool#6200 NO_DOC=bugfix

Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - old behavior is frozen and its logic is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as frozen. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool comparability module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - old behavior is frozen and its logic is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as frozen. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. More examples on the interface usage can be found here https://github.com/Lord-KA/doc/blob/Lord-KA/gh-7000-compat-module/doc/getting_started/using_compat.rst To add option to compat src one needs to insert its info into options table: ```lua local options = { json_escape_forward_slash = { old = true, new = false, default = true, brief = "<...>", doc = "https://github.com/tarantool/tarantool/wiki/compat_json_escape_forward_slash" } } ``` And add its postaction to postactions table (if the option is frozen, no need for postaction): ```lua local postaction = { json_escape_forward_slash = function(value) print(("esc_slash postaction was called with value %d!"):format(value)) end } ``` Every build-in option must have a Tarantool wiki page with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. For example, see json_escape_forward_slash patch (tarantoolgh-6200).

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - old behavior is frozen and its logic is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as frozen. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. More examples on the interface usage can be found here https://github.com/Lord-KA/doc/blob/Lord-KA/gh-7000-compat-module/doc/getting_started/using_compat.rst To add option to compat src one needs to insert its info into options table: ```lua local options = { json_escape_forward_slash = { old = true, new = false, default = true, brief = "<...>", doc = "https://github.com/tarantool/tarantool/wiki/compat_json_escape_forward_slash" } } ``` And add its postaction to postactions table (if the option is frozen, no need for postaction): ```lua local postaction = { json_escape_forward_slash = function(value) print(("esc_slash postaction was called with value %d!"):format(value)) end } ``` Every build-in option must have a Tarantool wiki page with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. For example, see json_escape_forward_slash patch (tarantoolgh-6200).

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - old behavior is frozen and its logic is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as frozen. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. More examples on the interface usage can be found here https://github.com/Lord-KA/doc/blob/Lord-KA/gh-7000-compat-module/doc/getting_started/using_compat.rst To add option to compat src one needs to insert its info into options table: ```lua local options = { json_escape_forward_slash = { old = true, new = false, default = true, brief = "<...>", doc = "https://github.com/tarantool/tarantool/wiki/compat_json_escape_forward_slash" } } ``` And add its postaction to postactions table (if the option is frozen, no need for postaction): ```lua local postaction = { json_escape_forward_slash = function(value) print(("esc_slash postaction was called with value %d!"):format(value)) end } ``` Every build-in option must have a Tarantool wiki page with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. For example, see json_escape_forward_slash patch (tarantoolgh-6200).

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - old behavior is frozen and its logic is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as frozen. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. More examples on the interface usage can be found here https://github.com/Lord-KA/doc/blob/Lord-KA/gh-7000-compat-module/doc/getting_started/using_compat.rst To add option to compat src one needs to insert its info into options table: ```lua local options = { json_escape_forward_slash = { old = true, new = false, default = true, brief = "<...>", doc = "https://github.com/tarantool/tarantool/wiki/compat_json_escape_forward_slash" } } ``` And add its postaction to postactions table (if the option is frozen, no need for postaction): ```lua local postaction = { json_escape_forward_slash = function(value) print(("esc_slash postaction was called with value %d!"):format(value)) end } ``` Every build-in option must have a Tarantool wiki page with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. For example, see json_escape_forward_slash patch (tarantoolgh-6200).

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - old behavior is frozen and its logic is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as frozen. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. More examples on the interface usage can be found here https://github.com/Lord-KA/doc/blob/Lord-KA/gh-7000-compat-module/doc/getting_started/using_compat.rst To add option to compat src one needs to insert its info into options table: ```lua local options = { json_escape_forward_slash = { old = true, new = false, default = true, brief = "<...>", doc = "https://github.com/tarantool/tarantool/wiki/compat_json_escape_forward_slash" } } ``` And add its postaction to postactions table (if the option is frozen, no need for postaction): ```lua local postaction = { json_escape_forward_slash = function(value) print(("esc_slash postaction was called with value %d!"):format(value)) end } ``` Every built-in option must have a Tarantool wiki page with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. For example, see json_escape_forward_slash patch (tarantoolgh-6200).

For unknown reason in upstream lua_cjson '/' was escaped while according to the standard [rfc4627] it is unnecessary and is questionably compatible with other implementations. It was decided that the change will be introduced using tarantool.compat (tarantoolgh-7000). The patch adds json-escape-forward-slash option to compat and its logic in lua_cjson and msgpuck. Fixes tarantool#6200 See also tarantool#7000 NO_DOC=docs on tarantool.wiki

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - old behavior is frozen and its logic is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as frozen. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. More examples on the interface usage can be found here tarantool#6912 (comment) To add option to compat src one needs to insert its info into options table: ```lua local options = { json_escape_forward_slash = { old = true, new = false, default = true, brief = "<...>", doc = "https://tarantool.io" } } ``` And add its postaction to postactions table (if the option is frozen, no need for postaction): ```lua local postaction = { json_escape_forward_slash = function(value) print(("esc_slash postaction was called with value %d!"):format(value)) end } ``` Every built-in option must have a Tarantool wiki page with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. For example, see json_escape_forward_slash patch (tarantoolgh-6200).

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - old behavior is frozen and its logic is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as frozen. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. More examples on the interface usage can be found here tarantool#6912 (comment) To add option to compat src one needs to insert its info into options table: ```lua local options = { json_escape_forward_slash = { old = true, new = false, default = true, brief = "<...>", doc = "https://tarantool.io" } } ``` And add its postaction to postactions table (if the option is frozen, no need for postaction): ```lua local postaction = { json_escape_forward_slash = function(value) print(("esc_slash postaction was called with value %d!"):format(value)) end } ``` Every built-in option must have a Tarantool wiki page with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. For example, see json_escape_forward_slash patch (tarantoolgh-6200).

It was decided that lua_cjson should have [tarantool.compat](tarantool/tarantool#7000) option that allows to toggle escaping '/'. For consistancy msgpuck is to switch the behavior too. This patch provides function that sets '/' to be escaped or not. Needed for tarantool/tarantool#6200

It was decided that lua_cjson should have tarantool.compat (tarantool/tarantool#7000) option that allows to toggle escaping '/'. For consistancy msgpuck is to switch the behavior too. This patch provides function that sets '/' to be escaped or not. Needed for tarantool/tarantool#6200

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here: https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here: https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here: https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here: https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here: https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here: https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here: https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

For unknown reason in upstream lua_cjson '/' was escaped while according to the standard [rfc4627] it is unnecessary and is questionably compatible with other implementations. It was decided that the change will be introduced using tarantool.compat (tarantoolgh-7000). The patch adds json_escape_forward_slash option to compat and its logic in lua_cjson and msgpuck. Requires tarantool#7060 Fixes tarantool#6200 See also tarantool#7000 NO_DOC=docs on tarantool.wiki

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here: https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here: https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here: https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here: https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here: https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here: https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here (private): https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

@TarantoolBot

As a followup to #6200 and a result of #6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes #7000 Needed for #6200 See also #6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here (private): https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

For unknown reason in upstream lua_cjson '/' was escaped while according to the standard [rfc4627] it is unnecessary and is questionably compatible with other implementations. It was decided that the change will be introduced using tarantool.compat (tarantoolgh-7000). The patch adds json_escape_forward_slash option to compat and its logic in lua_cjson and msgpuck. Requires tarantool#7060 Fixes tarantool#6200 See also tarantool#7000 NO_DOC=docs on tarantool.wiki

For unknown reason in upstream lua_cjson '/' was escaped while according to the standard [rfc4627] it is unnecessary and is questionably compatible with other implementations. It was decided that the change will be introduced using tarantool.compat (tarantoolgh-7000). The patch adds json_escape_forward_slash option to compat and its logic in lua_cjson and msgpuck. Requires tarantool#7060 Requires tarantool#8007 Fixes tarantool#6200 See also tarantool#7000 NO_DOC=docs on tarantool.wiki

@TarantoolBot

For unknown reason in upstream lua_cjson '/' was escaped while according to the standard [rfc4627] it is unnecessary and is questionably compatible with other implementations. It was decided that the change will be introduced using tarantool.compat (tarantoolgh-7000). The patch adds json_escape_forward_slash option to compat and its logic in lua_cjson and msgpuck. Requires tarantool#7060 Requires tarantool#8007 Fixes tarantool#6200 See also tarantool#7000 @TarantoolBot document Title: new compat option json_escape_forward_slash In the new behavior forward slash is not escaped in `json.encode()` and msgpack: ``` tarantool> compat.json_escape_forward_slash = 'new' --- ... tarantool> json.encode('/') --- - '"/"' ... tarantool> compat.json_escape_forward_slash = 'old' --- ... tarantool> json.encode('/') --- - '"\/"' ... ```

@TarantoolBot

For unknown reason in upstream lua_cjson '/' was escaped while according to the standard [rfc4627] it is unnecessary and is questionably compatible with other implementations. It was decided that the change will be introduced using tarantool.compat (gh-7000). The patch adds json_escape_forward_slash option to compat and its logic in lua_cjson and msgpuck. Requires #7060 Requires #8007 Fixes #6200 See also #7000 @TarantoolBot document Title: new compat option json_escape_forward_slash In the new behavior forward slash is not escaped in `json.encode()` and msgpack: ``` tarantool> compat.json_escape_forward_slash = 'new' --- ... tarantool> json.encode('/') --- - '"/"' ... tarantool> compat.json_escape_forward_slash = 'old' --- ... tarantool> json.encode('/') --- - '"\/"' ... ```

@TarantoolBot

As a followup to tarantool#6200 and a result of tarantool#6912, Tarantool compatibility module was implemented to simplify introduction of debatable behavior changes. Closes tarantool#7000 Needed for tarantool#6200 See also tarantool#6912 @TarantoolBot document Title: Tarantool compatibility module Compat module is basically a global options table with additional verbose interface and helper functions. There are tree stages of changing a behavior: - old behavior by default - new behavior by default - new behavior is frozen and the old behavior is removed on first two stages user can toggle options via interface and change the behavior according to his needs, on the last stage old behavior is removed from codebase and option is marked as obsolete. As compat is a global instance, options can be hardcoded into it or added in runtime e.g. by external module. There should be a link to tarantool.wiki/compat on the doc page. There are pages for each existing option with detailed description, list of known compatibility issues and some tips on detecting problems in codebase. Tutorial can be found here: https://github.com/tarantool/tarantool/wiki/compat%3Atutorial Full API description is here (private): https://www.notion.so/tarantool/tarantool-compat-introduce-compatibility-module-to-tarantool-8cb33e23932b490384c05f1cdfbf7baa

mp_snprint formats MsgPack data as a JSON-like string. According to the JSON format, the forward slash character isn't supposed to be escaped, but mp_snprint does escape it. Let's fix this. Note, this should be fine from the Tarantool compatibility point of view, because Tarantool uses this function only for presenting MsgPack data in an unspecified human-readable format, e.g. when printing to the log. If we need to format MsgPack data as valid JSON, we should use the internal Tarantool JSON encoder which respects the JSON serializer config and compat module options. See tarantool/tarantool#6200

Totktonada added the app label Jul 7, 2021

kyukhin closed this as completed Jul 13, 2021

Totktonada reopened this Jul 13, 2021

kyukhin added the bug Something isn't working label Jul 14, 2021

kyukhin added this to the wishlist milestone Jul 14, 2021

Lord-KA mentioned this issue Mar 10, 2022

lua_cjson: fix encode() escaping slash #6910

Merged

Lord-KA mentioned this issue Apr 6, 2022

Introduce compat module #7000

Closed

Lord-KA mentioned this issue Apr 20, 2022

Demo version of tarantool.compat #7051

Closed

Lord-KA mentioned this issue Apr 21, 2022

lua: introduce Tarantool compatibility module #7060

Merged

Lord-KA mentioned this issue May 4, 2022

Add encode-forward-slash logic tarantool/msgpuck#20

Closed

igormunkin closed this as completed in #6910 Dec 9, 2022

Totktonada mentioned this issue Jan 24, 2023

doc: cleanup released changelogs #8191

Merged

locker mentioned this issue Feb 1, 2023

Don't escape forward slash in mp_snprint tarantool/msgpuck#25

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

json.encode() escapes '/' #6200

json.encode() escapes '/' #6200

vasilky3 commented Jul 7, 2021

vasilky3 commented Jul 9, 2021

Totktonada commented Jul 13, 2021

Totktonada commented Mar 11, 2022 •

edited

json.encode() escapes '/' #6200

json.encode() escapes '/' #6200

Comments

vasilky3 commented Jul 7, 2021

vasilky3 commented Jul 9, 2021

Totktonada commented Jul 13, 2021

Totktonada commented Mar 11, 2022 • edited

Totktonada commented Mar 11, 2022 •

edited