Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store updated regression tests computed by runner #506

Open
rkunnema opened this issue Nov 10, 2022 · 3 comments
Open

Store updated regression tests computed by runner #506

rkunnema opened this issue Nov 10, 2022 · 3 comments

Comments

@rkunnema
Copy link
Member

The regression tests are not kept up to date very well. Moreover, the timings can be very different when run on gitlab's CI runner versus some user's computer. See #505.

My proposal: when the runner fails due to a difference between
case-studies-regression
and
case-studies,
it puts case-studies somewhere (e.g., using this mechanism https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts) and outputs a command for the user to obtain this data and overwrite their local case-studies-regression with it. The user confirms that the difference is okay but committing this artefact to the same PR.

@rkunnema rkunnema changed the title Regression tests Store updated regression tests computed by runner Nov 10, 2022
@rsasse
Copy link
Member

rsasse commented Nov 10, 2022

That sounds like a good idea if the runner data can be stored and retrieved easily that way! Great.

@jdreier
Copy link
Member

jdreier commented Nov 10, 2022

Sound great, will definitely look into that. We just need to make the process public somewhere so that people preparing a PR will know about it.

@rkunnema
Copy link
Member Author

Ideally, whenever regressionTests.py returns an error code, the runner outputs:

The regression tests returned an error code. The analysis results are stored in

$PLACE

Please inspect the regression test's output carefully (CONTRIBUTING.md lists 
the criteria). If your modifications are justified, update and commit the directory 
case-studies-regression in this PRs branch with the following commands:

$COMMANDS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants