Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing wellformedness warnings of pre-translated theory in interactive mode #485

Open
kevinmorio opened this issue Jul 26, 2022 · 0 comments

Comments

@kevinmorio
Copy link
Contributor

There are wellformedness checks that need to be performed before a theory is translated (e.g., for accountability and SAPiC).
However, these cannot currently be performed in src/Web/Theory.hs since the theory is already closed at this point.
See the relevant code:

report = checkWellformedness (removeTranslationItems (openTheory thy)) (get thySignature thy)
++ checkPreTransWellformedness (openTheory thy) -- FIXME: openTheory doesn't contain translated items, hence no warning is shown in the interactive mode

Possible solutions:

  • Cache the wellformedness report and include it in TheoryInfo
    Since I cannot think of a way a report can be invalided once a theory is loaded, this should be sound.
    Problem: WfErrorReport doesn't provide a Binary instance which is needed for inclusion in TheoryInfo

  • Store the OpenTheory in TheoryInfo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant