option to suppress default hovertext with plot_method = "ggplot" and node_type = "scatter" (with possible solution)

[mcsimenc]

Hi, when plot_method = "ggplot" and node_type = "scatter", there is always a string in the tooltip from these lines in R/plots.R:

mdf[["text"]] <- paste0(                                                         
  row, ": ", mdf[[1]], "<br>",                                                   
  col, ": ", mdf[[2]], "<br>",                                                   
  val, ": ", label_format_fun(mdf[[3]])                                          
)        

To add an option to control this, a couple conditionals can be added spanning lines 100 - 137, such as (tested):

  if(!suppress_default_hovertext)                                               
  {                                                                             
    mdf[["text"]] <- paste0(                                                    
      row, ": ", mdf[[1]], "<br>",                                              
      col, ": ", mdf[[2]], "<br>",                                              
      val, ": ", label_format_fun(mdf[[3]])                                     
    )                                                                           
  }                                                                             
                                                                                
  if (type == "heatmap") {                                                      
    geom <- "geom_tile"                                                         
    aes_mapping <- aes(fill = .data[[val]], text = text)                        
    geom_args <- list(                                                          
      color = grid_color,                                                       
      size = grid_size                                                          
    )                                                                           
  } else if (type == "scatter") {                                               
    geom <- "geom_point"                                                        
    geom_args <- list()                                                         
    if (!is.null(point_size_mat)) {                                             
      if(!suppress_default_hovertext)                                           
      {                                                                         
        mdf[["text"]] <- paste(                                                 
          mdf[["text"]], "<br>",                                                
          point_size_name, ": ", label_format_fun(mdf[[4]])                     
        )                                                                       
      }                                                                         
     aes_mapping <- aes(                                                        
       color = .data[[val]],                                                    
       text = text,                                                             
       size = .data[[point_size_name]]                                          
    )                                                                           
    } else {                                                                    
      geom_args[["size"]] <- grid_size                                          
      aes_mapping <- aes(                                                       
        color = .data[[val]],                                                   
        text = text                                                             
      )                                                                         
    }                                                                           
  }                                                                             
  if (!is.null(custom_hovertext)) {                                             
    if(!suppress_default_hovertext)                                             
    {                                                                           
      mdf[["text"]] <- paste0(mdf[["text"]], "<br>", custom_hovertext)          
    } else                                                                      
    {                                                                           
      mdf[["text"]] <- reshape2::melt(as.matrix(custom_hovertext))[[3]]         
    }                                                                           
  }

[talgalili]

Hey, Do you want to send a PR?

…

On Fri, 22 Dec 2023, 22:08 mcsimenc, ***@***.***> wrote: Hi, when plot_method = "ggplot" and node_type = "scatter", there is always a string from these lines in R/plots.R: mdf[["text"]] <- paste0( row, ": ", mdf[[1]], "<br>", col, ": ", mdf[[2]], "<br>", val, ": ", label_format_fun(mdf[[3]]) ) To add an option that prevents that a couple conditionals can be added, spanning lines 100 - 137, such as (tested): if(!suppress_default_hovertext) { mdf[["text"]] <- paste0( row, ": ", mdf[[1]], "<br>", col, ": ", mdf[[2]], "<br>", val, ": ", label_format_fun(mdf[[3]]) ) } if (type == "heatmap") { geom <- "geom_tile" aes_mapping <- aes(fill = .data[[val]], text = text) geom_args <- list( color = grid_color, size = grid_size ) } else if (type == "scatter") { geom <- "geom_point" geom_args <- list() if (!is.null(point_size_mat)) { if(!suppress_default_hovertext) { mdf[["text"]] <- paste( mdf[["text"]], "<br>", point_size_name, ": ", label_format_fun(mdf[[4]]) ) } aes_mapping <- aes( color = .data[[val]], text = text, size = .data[[point_size_name]] ) } else { geom_args[["size"]] <- grid_size aes_mapping <- aes( color = .data[[val]], text = text ) } } if (!is.null(custom_hovertext)) { if(!suppress_default_hovertext) { mdf[["text"]] <- paste0(mdf[["text"]], "<br>", custom_hovertext) } else { mdf[["text"]] <- reshape2::melt(as.matrix(custom_hovertext))[[3]] } } — Reply to this email directly, view it on GitHub <#300>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHOJBWUT67R77WK7DH6BTTYKXSCPAVCNFSM6AAAAABBAG4W6GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TINBXGA3DCNQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>