Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade hyper to 1.0 #650

Open
tusharmath opened this issue Nov 17, 2023 · 10 comments · May be fixed by #2013
Open

Upgrade hyper to 1.0 #650

tusharmath opened this issue Nov 17, 2023 · 10 comments · May be fixed by #2013
Labels
💎 Bounty type: chore Routine tasks like conversions, reorganization, and maintenance work.

Comments

@tusharmath
Copy link
Contributor

Renovate has created the base PR which doesn't pass the CI checks.

#636

Technical Requirements

  • Hyper version for both server should be updated to 1.0
  • No performance degradation should be observed
  • No tests should fail or require modification
@tusharmath
Copy link
Contributor Author

/bounty 120$

Copy link

algora-pbc bot commented Nov 17, 2023

💎 $120 bounty • Tailcall Inc.

Steps to solve:

  1. Start working: Comment /attempt #650 with your implementation plan
  2. Submit work: Create a pull request including /claim #650 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

🙏 Thank you for contributing to tailcallhq/tailcall!
🧐 Checkout our guidelines before you get started.

Attempt Started (GMT+0) Solution
🟢 @varshith257 May 14, 2024, 10:47:13 PM #1964
🟢 @ssddOnTop #2013

@ssddOnTop
Copy link
Member

Can you assign this to me

@ayewo
Copy link
Contributor

ayewo commented Nov 17, 2023

@tusharmath I’ve not got any new tickets in a bit 🙌

@scshiv29-dev
Copy link

Can I be assigned to this ?

@b4s36t4
Copy link
Contributor

b4s36t4 commented Nov 17, 2023

@tusharmath I request you to assign this to me.

I have done some digging into the issue why the compilation is issue.

I think you should put this to hold because of two reasons.

  1. We heavily depend on hyper and reqwest
  2. hyper and reqwest are co-related here in this context thus reqwest also should be updated according to the version of hyper due to mis-matching type definitions.

We should wait till reqwest get's same version update that matches with hypers latest version (reqwest is going to be breaking change)

more on this seanmonstar/reqwest#2039
Screenshot 2023-11-17 at 11 19 33 PM

@tusharmath
Copy link
Contributor Author

Thanks @b4s36t4 .

@ayewo let me keep this unassigned until reqwest also upgrades.

@github-actions github-actions bot added type: chore Routine tasks like conversions, reorganization, and maintenance work. and removed maintenance labels Dec 31, 2023
Copy link

Action required: Issue inactive for 30 days.
Status update or closure in 7 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Apr 29, 2024
@ssddOnTop ssddOnTop removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Apr 29, 2024
@varshith257
Copy link
Contributor

varshith257 commented May 14, 2024

/attempt #650

@ssddOnTop ssddOnTop linked a pull request May 23, 2024 that will close this issue
Copy link

algora-pbc bot commented May 23, 2024

💡 @ssddOnTop submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
6 participants