Introduced NumFactory and other factories #1147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of tests passed. Last two I am going to fix later. Implementing tests is now much easier, Mock* builders fill mandatory fields that are not tested. Implementor may focus only on values, that are related to tested Indicator/Rule/Criterion. At first glance is visible, what properties of bar Indicator/Rule/Criterion uses. |
sgflt
changed the title
|
Still in draft? |
- cleaned tests - use builders - eliminated different parameter orders - enforced usage of builder that belongs to series - TODO remove constructors in BaseBar and use BaseBarBuilder
- assumed always filled hi, lo - implementation does cont with nulls and os builder does too
- no need to manually calculate endTime
sgflt
force-pushed
the
introduce-num-factory
branch
from
255b2d2
to
a8400f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleaned tests
use builders
eliminated different parameter orders
enforced usage of builder that belongs to series
introduced possibility for caching most common constant values - one, two, hundred...
TODO remove constructors in BaseBar and use BaseBarBuilder
Partially Fixes #1134.
Fixes #1144
Changes proposed in this pull request:
standardize building flow
remove ambiguous tons of methods and constructors with random parameter order
f.e. Bar had open, hi, lo, close, Serie had open, close, hi, lo...
added an entry with related ticket number(s) to the unreleased section of
CHANGES.md