Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create releases more often #1123

Closed
Cypher01 opened this issue Nov 28, 2023 · 23 comments · Fixed by #1153
Closed

Create releases more often #1123

Cypher01 opened this issue Nov 28, 2023 · 23 comments · Fixed by #1153
Assignees
Labels

Comments

@Cypher01
Copy link

Simple request, please create releases more often.

0.15 is already over a year old and when adding 0.16-SNAPSHOT to Maven, on every build one can never be sure what version to get and what (potentially breaking) changes.

If you don't want to create final releases, at least make it possible to use a specific snapshot by date or month. Afaik it's possible to configure Nexus to not overwrite deployments, but keep all with a timestamp.

@TheCookieLab
Copy link
Member

@team172011 should we consider cutting a 0.16 release? We could also come up with a regular release cadence.

@Cypher01
Copy link
Author

Any news here? Any plans for a release? Or any plans to keep snapshot deployments with timestamps?

@TheCookieLab
Copy link
Member

I haven't heard from Simon but I'll assume the lack of pushback as acquiescence. I'll take a look at this shortly.

@TheCookieLab TheCookieLab self-assigned this Jan 5, 2024
@TheCookieLab
Copy link
Member

Unfortunately I don't seem to have access to perform releases. Will need to punt to @team172011

@Cypher01
Copy link
Author

@team172011 have you had a chance to look at this yet? Can I help anyhow?

@Cypher01
Copy link
Author

C'mon, am I the only one who finds that a bit disappointing?

What's stopping you from creating a release? Again, I'm willing to help.

@TheCookieLab
Copy link
Member

There's not much you can do as it's a permissions issue. No one active can publish releases to Nexus. I could potentially release it under a new project ID but that's unpalatable as it would break continuity.

@francescopeloi
Copy link
Contributor

is the real problem that @team172011 disappeared? Or just doesn't care anymore?

@TheCookieLab
Copy link
Member

TheCookieLab commented Mar 5, 2024 via email

@francescopeloi
Copy link
Contributor

francescopeloi commented Mar 5, 2024

When I say disappear I meant went to live to Maldives without internet and with the money made with a ta4j bot, so positive thinking here too.

@yamf0
Copy link

yamf0 commented Apr 17, 2024

Hi everyone, I came across this amazing project and started using it. I am just realising that the latest version released (and the one using my project) is more than 2 years old. I came across this discussion. I think I have some issues due to fixes not bein in V0.15 release.

Will this project be supported still? Should I start thinking on forking it and using a custom version?
Thanks, and I hope this continues since it is really cool and helpfull

@sgflt
Copy link
Contributor

sgflt commented Apr 18, 2024

I have accidentally started 1.0-SNAPSHOT. If you are interested in performance optimizations for backtesting and live trading. Different usecases needs different solutions. #1148

I was trying to be backward compatible, but I had to do a cut in favor to fix some design decisions.
And because my need for optimized version is urgent I have decided to be incompatible in terms of API.

I like this library, but it can be nice-tuned much more :)

@francescopeloi
Copy link
Contributor

I love the effort but I am not sure it's humanly possible to review a PR of 563 file changes with +44,564 lines and −43,944 lines. My suggestion is to break it up into much smaller PRs. But I am no-one here, just giving you my advice.

@sgflt
Copy link
Contributor

sgflt commented Apr 18, 2024

I agree, but PR touches core concepts that requires changes in almost all places. If I commmit just part, it will not compile. Maybe someday I can find a way how to commit things separately. For now, my goal is to adapt all current code and verify that it really works in efficient manner.

It must pass:

  1. current tests adapted to my vision of code flow
  2. backtesting performance improvement confirmation
  3. livetrading memory footprint reduce confirmation
  4. improved stability propagation of indicator

Therefore I just created a draft PR as window to my WIP on proof of concept. May be wrong and I will throw it away. May be "game changer" and we can find a way how to merge differnet paths. May be something between and we can cherrypick the best into separate PRs.

@Cypher01
Copy link
Author

I like these improvements, but I think this is another reason to come back to the original topic of this thread.

When (or if) the permission issue is resolved, as a first step v0.16 should be released. Afterwards one of the first updates for v0.17-SNAPSHOT could be your improvements @sgflt.

But same as @francescopeloi I'm also only a ta4j user and just share my thoughts here.

@TheCookieLab
Copy link
Member

I have submitted a request to Sonatype support inquiring if/how I can inherit the org.ta4j namespace. Barring this we'd have to create and publish under a new namespace which is far from ideal.

@TheCookieLab
Copy link
Member

0.16-SNAPSHOT is now out there. If everything looks good (everyone please give it a quick check over) I'll cut an official 0.16 release.

@Cypher01
Copy link
Author

Will there be also jars? And will the release also be published on Maven central repository?

@TheCookieLab
Copy link
Member

TheCookieLab commented May 21, 2024 via email

@Cypher01
Copy link
Author

Didn't show up on my side, I think it was a problem with browser cache, sorry. Now I see it, thx a lot!

@TheCookieLab
Copy link
Member

As for jars, I'll have to look into the process as it doesn't appear to be an automatic attachment by Github release. I can manually upload a locally built jar but that doesn't seem right.

@Cypher01
Copy link
Author

I would simply take the jars from Maven central repository (ta4j-core, ta4j-examples), download the 3 jars each and attatch to the release, same as release 0.15.

@TheCookieLab
Copy link
Member

TheCookieLab commented May 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants