Pyramid Trading - Scaling into a position - DCA Trading possible ?

[wesssup]

I have a question , is it possible to implement Pyramid Trading (https://www.investopedia.com/articles/trading/09/pyramid-trading.asp) also called scaling into a position or DCA .... ... is there a way to do it ?

I Guess in BaseTradingRecord line 204 ,

boolean newTradeWillBeAnEntry = currentPosition.isNew();
maybe should be adapted, as there could be many openings for one position... only one close.

Seen to the rest of the code there also maybe impact on costmodels..

[TheCookieLab]

There is not, at least not out of the box. TradingRecord only allows one open position at a time so you’d have to hack together multiple trading records to manage something similar. Enhancing TradingRecord to support multiple positions is on my todo list but as I’ve been preoccupied as of late. Perhaps Soon™

…

On Fri, Sep 1, 2023 at 5:53 AM Wesw ***@***.***> wrote: I have a question , in live trading it's easy to implement Pyramid Trading (https://www.investopedia.com/articles/trading/09/pyramid-trading.asp) also called scaling into a postion.... but I could not find it inside the backtesting ... is there a way to do it ? — Reply to this email directly, view it on GitHub <#1106>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQJ6FJTWPI7VMGYYF2GLB3XYGWBFANCNFSM6AAAAAA4HKFHUY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[nimo23]

For both, it would be good to just check for existing issues beforehand, rather than opening a new one and posting your comments, suggestions, or future plans here:

#755

[wesssup]

Agree,and I’ve seen the Projekt Roadmap | Ta4j - Technical Analysis for Java!<https://ta4j.github.io/ta4j-wiki/Roadmap-and-Tasks.html> But it’s not the same, multiple trades or scaling into a trade, or is due to the limited information not clear what you exact try to do… @TheCookieLab Many thanks for the input, if any input is needed , let me know :-)

[nimo23]

But it’s not the same, "multiple trades" or "scaling into a trade", or is due to the limited information not clear what you exact try to do…

I read again this issue. Yes, this issue has nothing to do with supporting "multiple trades".. well, then I don't understand why you liked the also wrong comment from #1106 (comment) which also has nothing to do with it..

Scaling into the position requires making decisions based on criteria. This is currently not possible. See here: #1054. Btw, scaling positions actually works with the existing trading record, but in blind mode as long as #1054 is not supported.

You see, searching for existing issues helps! Feel free to help.

[wesssup]

@TheCookieLab -->https://github.com/wesssup/ta4j It's not perfect, but it serves the purpose I needed for our app and strategies... (And, yes, it's on the head, due to the requirement in our DEVOPS) I ran the tests, and nothing appears to be broken. Pyramid trading is not unit-tested in this head/git... we apparently wrote the test on our own software stack....
Anyway, we ran a few scenarios with pyramid trading, and it appears to work as I intended.
Perhaps instead of vars, have two Strategy Property parameters, 'isPyramid' and 'depth'...

[TheCookieLab]

@wesw very promising - would you be willing to create a draft PR to facilitate collaboration for this?

…

On Fri, Sep 8, 2023 at 4:00 PM Wesw ***@***.***> wrote: @TheCookieLab <https://github.com/TheCookieLab> --> https://github.com/wesssup/ta4j It's not perfect, but it serves the purpose I needed for our app and strategies... (And, yes, it's on the head, due to the requirement in our DEVOPS) I ran the tests, and nothing appears to be broken. Pyramid trading is not unit-tested in this head/git... we apparently wrote the test on our own software stack.... Anyway, we ran a few scenarios with pyramid trading, and it appears to work as I intended. Perhaps instead of vars, have two Strategy Property parameters, 'isPyramid' and 'depth'... — Reply to this email directly, view it on GitHub <#1106 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQJ6FOAM65RFMQS5SRZEJ3XZN2NLANCNFSM6AAAAAA4HKFHUY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[nimo23]

would you be willing to create a draft PR to facilitate collaboration for this?

I would not agree with this PR. Looking into wesssup@846229d, it is nothing else than a workaround which pollutes a lot of our base classes only because of one concept. It is by far not a clear solution and would worsen the condition of the lib, since one concept was sloppily crammed into other concepts. @wesssup If it works for you, then leave it in your branch. I will not agree to put this into this lib. It would be far better to provide a clean solution to this problem as suggested here: #1054 (comment). I'm planning on doing a PR to solve #1054 (after pending PR's are merged) to make things like this possible. If #1054 was done, then this "pyramid trading" would end up being nothing more than a criterion type indicator (called PyramidCriterion). That would be the only clean solution.

[wesssup]

Hi @nimo23 , I never requested that you accept the changes.. I even suggested improvements. However you want to call it: a property, a criterion,…. its fine by me 😊 adaption is needed. Even so, I'm not requesting a merge with the TA4J repository. Even I wouldn't recommend it.

However, I can assure you that there is a workable implementation strategy with minimal issues with backwards compatibility. Since the entire ta4J model is based on opening only one position at a time, there are undoubtedly many base classes that are affected. It can be found in the basic operating and calculation functions, for example. Thus, you can picture.
Anyway, I can only draw the conclusion that I'm here in a very constructive way to offer a potential way to do it , WITH workable code, and you….
Anyway I can't wait to see how your PR works 😊. There is now a piece of code that can be used until that time, if someone wants to investigate it more deeply (like @TheCookieLab ) or test it in a new ‘java’ algorithmic trading strategy. (what exactly our goal is)

[wesssup]

@wesw very promising - would you be willing to create a draft PR to facilitate collaboration for this?

@TheCookieLab I'm sorry, but I currently have too much on my plate. Do whatever you want to do with it 😊 . Although there is still a lot of work to be done....., for us, things are going as planned, and we get the same data from our strategy as from the TradingView Pine Strategy Tester....happy camper here 😊

==> Draft #1113

[nimo23]

There is now a piece of code that can be used until that time, if someone wants to investigate it more deeply (like @TheCookieLab ) or test it in a new ‘java’ algorithmic trading strategy. (what exactly our goal is)

No, problem! @TheCookieLab has its own branch. If he wants to merge it in his own branch, he can do it whatsoever. But your PR is nothing more than a workaround and is far from a clean and future-proof solution - it's a typical dirty hack :)