Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convolution padding same on even-valued arguments #6

Open
triwahyuu opened this issue Apr 15, 2020 · 2 comments
Open

convolution padding same on even-valued arguments #6

triwahyuu opened this issue Apr 15, 2020 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@triwahyuu
Copy link

is there any possibility for the 'same' padding convolution to work on even values of kernel size, stride, and dilation?

@szymonmaszke
Copy link
Owner

szymonmaszke commented Apr 17, 2020

See PyTorch's Feature Request, in case of torchlayers there are also some quirks one would have to solve as well.

same padding for even values would have to be done by adding asymmetric padding before convolution with one of specific modes (see here). I'm not yet sure how I'd like to follow through with this (some 3D, 1D layers are missing for some padding modes, so I might have to implement my own new layer padding any dimension).

Should be possible to do though, will sit on it during the weekend and keep you updated if anything changes.

@szymonmaszke szymonmaszke pinned this issue Apr 17, 2020
@triwahyuu
Copy link
Author

thanks for the answer.
I still don't quite understand what the padding argument in the convolution really

@szymonmaszke szymonmaszke added bug Something isn't working enhancement New feature or request labels May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants