Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clamp mtime to $SOURCE_DATE_EPOCH #2635

Closed
septatrix opened this issue Apr 15, 2024 Discussed in #2571 · 1 comment · Fixed by #2721
Closed

Clamp mtime to $SOURCE_DATE_EPOCH #2635

septatrix opened this issue Apr 15, 2024 Discussed in #2571 · 1 comment · Fixed by #2721
Labels

Comments

@septatrix
Copy link
Contributor

Discussed in #2571

Originally posted by septatrix March 30, 2024

TL;DR: Current implementation of SourceDateEpoch= is very drastic as the mtime of every file is updated.

An alternative suggested in the discussion is to clamp the mtime of files newer than SourceDateEpoch= instead of setting it for all files. This is way less invasive and also the approach used by adopted by Fedora: https://fedoraproject.org/wiki/Changes/ReproducibleBuildsClampMtimes

@keszybz
Copy link
Member

keszybz commented May 22, 2024

Yeah. In hindsight, this is a very specific implementation choice. Simple people want to just reset the times, but for most uses this is too much, because the timestamps of files installed from packages are correct and reproducible and we don't want to get rid of them.

keszybz added a commit to keszybz/mkosi that referenced this issue May 22, 2024
keszybz added a commit to keszybz/mkosi that referenced this issue May 22, 2024
behrmann pushed a commit that referenced this issue May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants