Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HD seed like LTC #534

Open
skironDotNet opened this issue Sep 8, 2023 · 6 comments
Open

Support HD seed like LTC #534

skironDotNet opened this issue Sep 8, 2023 · 6 comments

Comments

@skironDotNet
Copy link

Please describe the feature you'd like to see added.

Support HD seed like LTC. Syscoin seems to support blank wallet creation like LTC but can't set HD seed
image

image

Is your feature related to a problem, if so please describe it.

No response

Describe the solution you'd like

No response

Describe any alternatives you've considered

No response

Please leave any additional context

No response

@Frank-GER
Copy link
Member

Your screenshot shows the creation of a descriptor wallet, that is NOT a legacy wallet.

Descriptor wallets were first introduced with btc v 0.21.

Unmark "Descriptor Wallet" when creating the empty wallet, so you get a legacy one and than you can use 'sethdseed'.

@skironDotNet
Copy link
Author

I'll test that.

What the Descriptor wallet means? Any documentation on this, just curious.

Thanks for quick response to this

@Frank-GER
Copy link
Member

Frank-GER commented Sep 9, 2023

@sidhujag
Copy link
Member

Maybe LTC dropped the ball keeping up to date with BTC?

@Frank-GER
Copy link
Member

Looks like it.
LTC has last commit Mar 2 and even before hardly any updates.
Still using gitian, bionic, g++8 to build.

@skironDotNet
Copy link
Author

@Frank-GER I just tested when unchecked Descriptor wallet, and getting nice warning that the wallet is legacy.
I also notice that when I create "random" HD wallet, the "old fashion" way, the HD icon is showing, when creating a new blank wallet, the HD is crossed out, and that makes sense because blank wallet has no addresses and no HD seed, but when I ran sethdseed in console, the icon should change to HD. I tried to close the wallet and open again, and now HD was shown. So small user experience, flow bug.

Other than that I was able to restore HD seed from one wallet to another, refill key pool (because I set 1 so wallets are smaller to start) and was able to rescanblockchain and transaction were re-populated in the new wallet, so the HD feature works as expected.

Not closing the issue in case you would like to do something about that Descriptor wallet flag? Maybe some star with info that HD works only with non-descriptor wallet? Otherwise feel free to close.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants