Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change font folder structure #2

Open
AriTheElk opened this issue Sep 14, 2018 · 0 comments
Open

Change font folder structure #2

AriTheElk opened this issue Sep 14, 2018 · 0 comments
Labels
good first issue Good for newcomers

Comments

@AriTheElk
Copy link
Member

The fonts/ directory was created on a whim before there was much direction in this project (this plugin started as a simple proof-of-concept). Because of that, the folder structure of the fonts will become increasingly difficult to manage if it's maintained as-in. So we need to take steps to improve the structure of that.

The Problem

Currently the folder structure looks something like this:

fonts/
    DejaVuSansCondensed_black_bold_16.fnt
    DejaVuSansCondensed_black_bold_16.png
    DejaVuSansCondensed_black_bold_24.fnt
    DejaVuSansCondensed_black_bold_24.png
    ...

This will become a mess when adding new fonts.

The Solution

Ideally, I think a structure like this would improve manageability of adding many fonts in the future

fonts/
    DejaVuSansCondensed/
        black/
            bold_16.fnt
            italic_16.fnt
            normal_16.fnt

I'm totally open to suggestions on this, it's not set in stone. I realize that there are many different ways to handle the structure. Instead of having black/, maybe it's better to group by size. So it would be DejaVuSansCondensed/16/bold_black.fnt. Maybe go even deeper and do DejaVuSansCondensed/16/black/bold.fnt

Notes

It might be better to wait until #1 is addressed since the color portion of the path is likely to be removed once we have dynamic colors.

@AriTheElk AriTheElk added the good first issue Good for newcomers label Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant