Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes with large libraries #18

Open
seavord opened this issue Apr 6, 2024 · 14 comments
Open

Crashes with large libraries #18

seavord opened this issue Apr 6, 2024 · 14 comments
Assignees
Labels
bug Something isn't working testing Testing is in-progress

Comments

@seavord
Copy link

seavord commented Apr 6, 2024

i have over 3500 games and it seems to crash as soon as it hits 2500 games

@syntax-tm
Copy link
Owner

Can you upload the error log file? Should be in the logs subdirectory.

I know people with similar library sizes didn't run into any issues but who knows maybe something changed

@syntax-tm syntax-tm self-assigned this Apr 7, 2024
@syntax-tm syntax-tm added the bug Something isn't working label Apr 7, 2024
@seavord
Copy link
Author

seavord commented Apr 7, 2024

errors.txt

@seavord
Copy link
Author

seavord commented Apr 7, 2024

there you go

@syntax-tm
Copy link
Owner

syntax-tm commented Apr 16, 2024

@seavord When you get the chance, can you please try with this version? I also updated the logging to hopefully provide more information so if there is still an issue if you could include the new logs that would be great. Thanks!

https://github.com/syntax-tm/SteamAchievementManager/releases/tag/v0.6.0-alpha

@syntax-tm syntax-tm added the testing Testing is in-progress label Apr 16, 2024
@DerekTurtleRoe
Copy link

I have a little under 10,000 games in my library and I also get a crash after it finishes loading about 3900 of the game names, I included both generated logs here:

errors.txt
log.txt

This was generated using the 0.6.0 alpha provided above.

@syntax-tm
Copy link
Owner

Okay looking at the errors I'm guessing that you're getting blocked by the Steam store API. Theoretically, if you wait and start the app eventually it will have cached all of the store information. The version doesn't matter as they all save that cache to %LOCALAPPDATA%\SAM.

You could try and delete the stuff that's there (I would move it in case you still need it to pick up where it last left off). It's possible that it crashed in the middle of writing one of those files and they're no longer valid.

I can also, just for you, make a debug build with the store stuff disabled if you want to try that? Would take me a few minutes but should be doable. That would at least tell us if the store data is the issue or not. I want to say that I automatically retry if you get a 429 (Too Many Requests) and if they're just blocking you that would likely be a 401 or 403.

@syntax-tm
Copy link
Owner

syntax-tm commented Apr 17, 2024

I tried to upload it but the limit on GitHub is 25 MB and the zip is 67 MB. So, I put it on my OneDrive here.

@DerekTurtleRoe
Copy link

I tried to upload it but the limit on GitHub is 25 MB and the zip is 67 MB. So, I put it on my OneDrive here.

That build works fine for me! So I think it might've been exactly what you said. 😄

@seavord
Copy link
Author

seavord commented Apr 18, 2024

@seavord When you get the chance, can you please try with this version? I also updated the logging to hopefully provide more information so if there is still an issue if you could include the new logs that would be great. Thanks!

https://github.com/syntax-tm/SteamAchievementManager/releases/tag/v0.6.0-alpha

crashes after 8000 games

I tried to upload it but the limit on GitHub is 25 MB and the zip is 67 MB. So, I put it on my OneDrive here.

crashes after 4000 games

still not sure why its crashing so much it seems to crash after 18%

edit: getting this in logs

"SAM: 2024-04-18 23:49:20,225 [1] INFO App [(null)] - Application startup.
SAM: 2024-04-18 23:49:29,164 [1] WARN SAM.Core.LocationHelper [(null)] - Unknown location format ('United Kingdom (Great Britain)'). Location will not be shortened.
SAM: 2024-04-18 23:49:29,500 [1] INFO HomeViewModel [(null)] - HomeViewModel Loaded
SAM: 2024-04-18 23:49:36,016 [1] INFO App [(null)] - Application startup.
SAM: 2024-04-18 23:49:43,280 [1] WARN SAM.Core.LocationHelper [(null)] - Unknown location format ('United Kingdom (Great Britain)'). Location will not be shortened.
SAM: 2024-04-18 23:50:55,489 [1] INFO App [(null)] - Application startup.
SAM: 2024-04-18 23:50:58,310 [1] WARN SAM.Core.LocationHelper [(null)] - Unknown location format ('United Kingdom (Great Britain)'). Location will not be shortened.
SAM: 2024-04-18 23:50:58,644 [1] INFO HomeViewModel [(null)] - HomeViewModel Loaded
"

@syntax-tm
Copy link
Owner

Hey @seavord, that warning is not relevant. It's just saying that your location is either too few or too many comma-separated segments to be able to shorten it (in this case it's too few since it's only one segment). If you're curious this is the relevant bit of code that logs the warning:

var segments = location.Split(',', StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries);

if (segments.Length is < 2 or > 3)
{
    // if it's anything else don't bother trying to shorten it
    log.Warn($"Unknown location format ('{location}'). Location will not be shortened.");
    return;
}

Currently nothing actually uses that profile info it's just loaded automatically on startup.

Anyways, there should be a separate log file just for errors called errors.txt that'll be in the same folder as log.txt. If it's missing or empty then you're going to have to check the Windows Event Viewer.

You can ping me on Discord if you want help looking into it (@Gundwn).

@seavord
Copy link
Author

seavord commented Apr 19, 2024

event viewer says

Application: SAM.exe
CoreCLR Version: 7.0.1724.11508
.NET Version: 7.0.17
Description: The process was terminated due to an internal error in the .NET Runtime at IP 0x79F803C6 (0x79ED0000) with exit code 0x80131506.

and

Faulting application name: SAM.exe, version: 1.0.0.0, time stamp: 0x65ce0000
Faulting module name: coreclr.dll, version: 7.0.1724.11508, time stamp: 0x65ce991a
Exception code: 0xc0000005
Fault offset: 0x000b03c6
Faulting process ID: 0x0xC7E4
Faulting application start time: 0x0x1DA927766DD7374
Faulting application path: SAM.exe
Faulting module path: Fcoreclr.dll
Report ID: ec21b439-3694-4bf0-8e00-fabd9364388f
Faulting package full name:
Faulting package-relative application ID:

weirdly enough after loading the second one then loading the 1st again it now loads albiet keeps freezing but the progress has gone up, but trying to load just loading the 1st then the 2nd it crashes, so somehow i have to load the second then the first ...

@seavord
Copy link
Author

seavord commented Apr 19, 2024

nvm as soon as i clicked the window it crashed lol

@syntax-tm
Copy link
Owner

I'm almost done with a big update that should hopefully fix a lot of things. I'll try to get it done today.

@syntax-tm
Copy link
Owner

@seavord Any chance you'd be down to try the new changes? I've rewritten a lot of things so I apologize for the delay. It'd be nice if someone, or a few people, would be willing to try it before I made a new release to make sure I didn't miss anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Testing is in-progress
Projects
Development

No branches or pull requests

3 participants