-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite Error Windows from Eyedropper #3288
Comments
Please check first with (at least) 1.4.4 and current dev version. |
Just checked on the 1.4.4 release and replicated the bug using the same process. Not sure I have the time right now to get the dev version up and running on my machine. Also a note: I'm guessing v1.4.4 is a stable release. Given that, why does the synfig.org "purchase" form (https://synfig.gumroad.com/l/synfig) give users the 1.4.2 release for the Windows 64bit exe? That is why I had an older version. |
Good to know, let's the "Boss" @morevnaproject be aware of this for check. Did you try with a (portable) dev release? |
Thanks for the link! Same bug with same error messages, though it briefly froze when I first clicked the eyedropper this time (no warnings/errors popped up in the console yet, though). When I did attempt to select a color, each new error box seemed to align with the console warning |
Here we prevent to emit signal_edited_ for Color and Gradient dialog windows when presented by Parameter Panel. Those dialogs may be opened by a cell and try to update the parameter value related to another one, as it just remembered its parameter tree path. Reproducible steps: 1. Create a region layer 2. Create an outline layer 3. Click on color parameter to edit it 4. Without closing color dialog, select the region layer instead 5. Try to edit the color in dialog 6. Error Message appears fix synfig#3288
Here we prevent to emit signal_edited_ for Color and Gradient dialog windows when presented by Parameter Panel. Those dialogs may be opened by a cell and try to update the parameter value related to another one, as it just remembered its parameter tree path. Reproducible steps: 1. Create a region layer 2. Create an outline layer 3. Click on color parameter to edit it 4. Without closing color dialog, select the region layer instead 5. Try to edit the color in dialog 6. Error Message appears fix synfig#3288
@jnilken |
Describe the bug
When attempting to use the eyedropper, I go the error "Unable to set all layer parameters," but the eyedropper is apparently still active. Attempting to close the error window results in the eyedropper trying to pick the color of the error box and spawned new error windows for every click. The escape and enter key all seem to also select colors and spawn new errors instead of letting me exit. I can't close the window from my taskbar, so I either have to use task manager or wait for it to crash. Recovery saved my work, so no big issues there.
Cause of Error: I opened the color picker then realized the color I wanted was on the bottom layer and covered. I moved that layer while the color picker was open, then attempted to sample from it. The correct color was chosen before the error occurred. On my second attempt, the same error did not happen.
My layers were an advanced outline, a region, and a png (in that order from top to bottom). Then I moved the png to the top layer. There is an error that occurs before "Unable to set all layer parameters," but it is covered too fast for me to easily read it.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The color is selected, or the resulting error can be exited.
Screenshots
System information:
Additional comments
I was able to reproduce it consistently. This only occurs when I move and sample from a bitmap image, not a region or outline.
The text was updated successfully, but these errors were encountered: