Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Error Windows from Eyedropper #3288

Open
jnilken opened this issue Dec 7, 2023 · 6 comments · May be fixed by #3373
Open

Infinite Error Windows from Eyedropper #3288

jnilken opened this issue Dec 7, 2023 · 6 comments · May be fixed by #3373
Labels

Comments

@jnilken
Copy link

jnilken commented Dec 7, 2023

Describe the bug
When attempting to use the eyedropper, I go the error "Unable to set all layer parameters," but the eyedropper is apparently still active. Attempting to close the error window results in the eyedropper trying to pick the color of the error box and spawned new error windows for every click. The escape and enter key all seem to also select colors and spawn new errors instead of letting me exit. I can't close the window from my taskbar, so I either have to use task manager or wait for it to crash. Recovery saved my work, so no big issues there.

Cause of Error: I opened the color picker then realized the color I wanted was on the bottom layer and covered. I moved that layer while the color picker was open, then attempted to sample from it. The correct color was chosen before the error occurred. On my second attempt, the same error did not happen.

My layers were an advanced outline, a region, and a png (in that order from top to bottom). Then I moved the png to the top layer. There is an error that occurs before "Unable to set all layer parameters," but it is covered too fast for me to easily read it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Parameters (for a region)
  2. Click on the color box next to the Color parameter to open the selector
  3. Move the bitmap layer to the top
  4. Attempt to select a color from bitmap image
  5. See error

Expected behavior
The color is selected, or the resulting error can be exited.

Screenshots
image

System information:

  • OS: Windows 10
  • OS version: 10.0.19045 Build 19045
  • Synfig version: 1.4.2

Additional comments
I was able to reproduce it consistently. This only occurs when I move and sample from a bitmap image, not a region or outline.

@BobSynfig
Copy link
Collaborator

Please check first with (at least) 1.4.4 and current dev version.
Lots of bugs have been corrected since 1.4.2

@BobSynfig BobSynfig changed the title Infinite Error Windows from Eyedropper [ 1.4.2 ] Infinite Error Windows from Eyedropper Dec 13, 2023
@jnilken
Copy link
Author

jnilken commented Dec 16, 2023

Just checked on the 1.4.4 release and replicated the bug using the same process. Not sure I have the time right now to get the dev version up and running on my machine.

Also a note: I'm guessing v1.4.4 is a stable release. Given that, why does the synfig.org "purchase" form (https://synfig.gumroad.com/l/synfig) give users the 1.4.2 release for the Windows 64bit exe? That is why I had an older version.

@jnilken
Copy link
Author

jnilken commented Dec 16, 2023

Image of the same bug on v1.4.4

image

@BobSynfig
Copy link
Collaborator

Also a note: I'm guessing v1.4.4 is a stable release. Given that, why does the synfig.org "purchase" form (https://synfig.gumroad.com/l/synfig) give users the 1.4.2 release for the Windows 64bit exe? That is why I had an older version.

Good to know, let's the "Boss" @morevnaproject be aware of this for check.

Did you try with a (portable) dev release?
The last available from AppVeyor is available here: https://ci.appveyor.com/project/Synfig/synfig/builds/48718219/artifacts (link expires Jan 9th 2024)

@jnilken
Copy link
Author

jnilken commented Dec 18, 2023

Thanks for the link! Same bug with same error messages, though it briefly froze when I first clicked the eyedropper this time (no warnings/errors popped up in the console yet, though). When I did attempt to select a color, each new error box seemed to align with the console warning Cancel depth: 0

@rodolforg rodolforg added Bug and removed Outdated labels Jun 9, 2024
@rodolforg rodolforg changed the title [ 1.4.2 ] Infinite Error Windows from Eyedropper Infinite Error Windows from Eyedropper Jun 9, 2024
rodolforg added a commit to rodolforg/synfig that referenced this issue Jun 9, 2024
Here we prevent to emit signal_edited_ for Color and Gradient dialog
windows when presented by Parameter Panel.

Those dialogs may be opened by a cell and try to update the parameter
value related to another one, as it just remembered its parameter tree
path.

Reproducible steps:
1. Create a region layer
2. Create an outline layer
3. Click on color parameter to edit it
4. Without closing color dialog, select the region layer instead
5. Try to edit the color in dialog
6. Error Message appears

fix synfig#3288
rodolforg added a commit to rodolforg/synfig that referenced this issue Jun 9, 2024
Here we prevent to emit signal_edited_ for Color and Gradient dialog
windows when presented by Parameter Panel.

Those dialogs may be opened by a cell and try to update the parameter
value related to another one, as it just remembered its parameter tree
path.

Reproducible steps:
1. Create a region layer
2. Create an outline layer
3. Click on color parameter to edit it
4. Without closing color dialog, select the region layer instead
5. Try to edit the color in dialog
6. Error Message appears

fix synfig#3288
@rodolforg
Copy link
Contributor

rodolforg commented Jun 10, 2024

@jnilken
Long time after the report, now PR #3373 fixes it. I hope.
Could you test it, please? https://ci.appveyor.com/api/buildjobs/cctv7pxaq7ijd23t/artifacts/SynfigStudio-1.5.2-testing-2024-06-09-win64-7cfc0.zip (link expires July 9)
Please note that is a dev. version. Do not save your projects from 1.4.x versions with it without a proper backup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants