-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editable curves in Graph Panel #267
Comments
I think it's best to implement this in current Graph Panel. |
Shouldn't matter from user perspective and from developer perspective i have no idea which would be easier - haven't looked much at the code of either docks. |
We need that in Graph Panel. This is highly requested feature from many artists. |
@morevnaproject Implementing this would be terrific! I honestly tried to use and understand the TCB vs. other interpolations, but it's just not the same. I have an After Effects background and the keyframe interpolation, or what you call waypoints, always behaves in ways that the artist can predict, however for certain types of animation you are practically required to use (bezier) curves; they are key to create complicated patterns in motion graphics. Since I've noticed more activity lately in the repo, I'll gladly test the latest dev builds and submit every detailed bug report I can, I have a track record with testing FOSS. Also I want to submit feature requests that myself and other professional colleagues of mine have made when trying out the software. Hopefully we can finally see Synfig getting more support and market share in the open-source graphics ecosystem 🙂 |
Indeed it would be nice but it would surely introduce more bugs, especially with multi-values waypoints (like colors). |
@BobSynfig For all intents and purposes I wholly agree that stabilizing in any FOSS comes first, however do have in mind that this request has been made by the community even much before than this github issue, and it should have been a priority ever since along the graphics engine overhaul and the rendering pipeline. Hopefully stabilizing doesn't take more than a year or so now that there's some funding and you're helping 😉 It would be great to start getting more feature flexibility in Synfig, but cleaning the house from bugs for sure comes first 🙂 |
@Jose-Moreno Yes, that feature is a long-awaited by all us, and (as far as I know) it is a major roadblock, which prevents professional animators form using Synfig. This is why I pinned this issue to bring more attention to it. And it is in our roadmap - https://synfig-docs-dev.readthedocs.io/en/latest/common/roadmap.html
Thank you, we will appreciate your help here for sure! ^__^ |
I think we can split this task in several steps. Step 0: here is how Graphs Panel look at the moment: Step 1: Add markers, which corresponding to Waypoints Step 2: Allow user to change values (curves) by dragging those markers (make markers draggable using mouse). Step 3: Implementing control points for TCB Waypoints TCB Waypoints are shown with green dots. If you right-click on TCB Waypoint (1) and choose "Edit" then you will see a dialog with parameters, which allows tweak shape of the curve (2). Those parameters are kinda clumsy and hard to understand. So, I think it's okay to create handles that allow to change "Bias" parameter only. (On the illustration: dragging handle 1 will change Bias parameter). Step 4: Implementing Bezier Waypoints Since TCB Waypoints are not very flexible to define curve shape, we need to introduce bew type of Waypoint, which is defined by Bezier curve. This is how editable Bezier Curves work in OpenToonz - Step 5: Make Bezier Waypoints editable using mouse. Add handles (as in step 3) and make them draggable with mouse. This is it, I hope I didn't forgot anything. ^__^ |
I would like to work on this project as a part of GSoC 2019, it would be great of I could get some guidance on how to proceed!! |
@maitreyi0505 Great! Please consider that there is already some competition among students around “Editable animation curves in Graphs Panel” project. If you do not mind that, then I suggest to start by implementing this feature as a proof of your eligibility - #783 |
TCB waypoints are already implemented. We will need Bezier waypoints implemented as part of this project. |
@rodolforg is working on this via #982. |
Alternative timetrack dock/mode, which would present parameter values as a graph (as graphs dock currently does) and allow to edit waypoints, including their parameters (e.g. curve handles for curve interpolation)
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: