S(0)==False->True (should be False)

[NamDuong2]

sympy/sympy/core/numbers.py

Line 1591 in af0c855

def __eq__(self, other):

[smichr]

If I am interpreting correctly, the code you cite should return False, so this must not be the code that is generating the True.

[NamDuong2]

If I am interpreting correctly, the code you cite should return False, so this must not be the code that is generating the True.
But according to the source code, it said return True while it should be return False.
def eq(self, other):
try:
other = _sympify(other)
except SympifyError:
return NotImplemented
if not isinstance(other, Number):
# S(0) == S.false is False
# S(0) == False is True
return False

[asmeurer]

This probably could be changed. I don't know if it would break anything. The reason it's like that is because the Python bool False really is equal to 0.

[NamDuong2]

This probably could be changed. I don't know if it would break anything. The reason it's like that is because the Python bool False really is equal to 0.

I understand what you mean but my point is there seem to be a conflict in the code itself. Because if you call isintance(False, Number) will return False.

[asmeurer]

I see. The problem is that Integer also defines __eq__, which is what gets used. We should clarify the desired behavior here and update the comments in the code.