[WIP] Fix Intl for PHP >= 7.3 and ICU >= 56 #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@nicolas-grekas , waiting for your approval of the first step. Ready to work on the rest. |
|
LGTM thanks! |
|
@nicolas-grekas , as you can see in https://travis-ci.org/symfony/polyfill/jobs/495391071, five |
glensc
reviewed
Oct 20, 2020
| private static $ASCII = "\x20\x65\x69\x61\x73\x6E\x74\x72\x6F\x6C\x75\x64\x5D\x5B\x63\x6D\x70\x27\x0A\x67\x7C\x68\x76\x2E\x66\x62\x2C\x3A\x3D\x2D\x71\x31\x30\x43\x32\x2A\x79\x78\x29\x28\x4C\x39\x41\x53\x2F\x50\x22\x45\x6A\x4D\x49\x6B\x33\x3E\x35\x54\x3C\x44\x34\x7D\x42\x7B\x38\x46\x77\x52\x36\x37\x55\x47\x4E\x3B\x4A\x7A\x56\x23\x48\x4F\x57\x5F\x26\x21\x4B\x3F\x58\x51\x25\x59\x5C\x09\x5A\x2B\x7E\x5E\x24\x40\x60\x7F\x00\x01\x02\x03\x04\x05\x06\x07\x08\x0B\x0C\x0D\x0E\x0F\x10\x11\x12\x13\x14\x15\x16\x17\x18\x19\x1A\x1B\x1C\x1D\x1E\x1F"; | ||
|
|
||
| public static function isNormalized($s, $form = self::NFC) | ||
| if (version_compare(PHP_VERSION, '7.3', '>=') && defined('INTL_ICU_VERSION') && version_compare(INTL_ICU_VERSION, '56', '>=')) { |
There was a problem hiding this comment.
don't do version_compare on PHP_VERSION, use compare PHP_VERSION_ID instead
|
I'm closing because this staled. Please submit again when you're ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170
Closes #163
Since
PHP 7.3the behavior of the Intl extension depends on the ICU version (see this snippet as example).Thus to be able to test the full range of outcomes and to close #170, we need
PHP 7.3binary withICU >= 56. Since for Travis CI the ICU version cannot be configured (see travis-ci/travis-ci#3616) and currently is lower than56, I decided to compile php manually. The result is cached via standard Travis caching to optimize subsequent builds.PHP 7.3andICU 63.1: https://travis-ci.org/symfony/polyfill/jobs/494652921Normalizer::FORM_KC_CF