Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:auth] Adapt command to use the upcoming LogoutRouteLoader #1375

Open
maelanleborgne opened this issue Oct 17, 2023 · 1 comment · May be fixed by #1376
Open

[make:auth] Adapt command to use the upcoming LogoutRouteLoader #1375

maelanleborgne opened this issue Oct 17, 2023 · 1 comment · May be fixed by #1376

Comments

@maelanleborgne
Copy link
Contributor

This PR has been merged a few days ago : symfony/symfony#50946
We now don't need to make a controller to match the logout path, we just need to register a route loader that deals with loading a route for each firewall that has a logout.path.

It would be nice to have this change reflected in the make:auth command.

I've started to work on this, but I'm not sure if there are any plan to release a new version of the maker-bundle with minimum compatibility with symfony 6.4 / 7, or if I should test if the new LogoutRouteLoader service exists and change the behaviour accordingly.

@weaverryan
Copy link
Member

Hey!

I've started to work on this, but I'm not sure if there are any plan to release a new version of the maker-bundle with minimum compatibility with symfony 6.4 / 7, or if I should test if the new LogoutRouteLoader service exists and change the behaviour accordingly.

That's an excellent question. The next release will still probably require 6.3, so we should test for the LogoutRouteLoader service and generate the code conditionally. We're going to be a little more strict on MakerBundle version support (i.e. support less versions of Symfony at a time), but I think the next release will still be ^6.3|^7.0

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants