Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Make templates configurable #228

Open
jrmyio opened this issue Mar 25, 2015 · 1 comment
Open

Make templates configurable #228

jrmyio opened this issue Mar 25, 2015 · 1 comment

Comments

@jrmyio
Copy link

jrmyio commented Mar 25, 2015

In https://github.com/symfony-cmf/BlockBundle/blob/master/Resources/config/services.xml all the blocks are defined. The block services have a third argument which is the template that gets rendered.

Personally I dislike making a BlockBundle myself to extend the cmf, nor do I like adding templates in app/Resources.

Is it an option to add the templates to the parameters so one can overwrite them?

@dbu
Copy link
Member

dbu commented Mar 25, 2015

i guess it makes sense to make them configureable. we should add them to the configuration, like we have it for the class https://github.com/symfony-cmf/BlockBundle/blob/master/DependencyInjection/Configuration.php#L48 and adjust the xml schema accrodingly, and then copy those settings here https://github.com/symfony-cmf/BlockBundle/blob/master/DependencyInjection/CmfBlockExtension.php#L89

having a default value in the configuration will avoid having to actually define <parameter> in the service definition.

do you want to do a pull request with that?

@lsmith77 lsmith77 added this to the 1.3 milestone Jun 17, 2015
@dbu dbu removed this from the 1.3 milestone Feb 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants