Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting update the simplify function #405

Open
JJShi92 opened this issue May 21, 2022 · 4 comments
Open

Requesting update the simplify function #405

JJShi92 opened this issue May 21, 2022 · 4 comments

Comments

@JJShi92
Copy link

JJShi92 commented May 21, 2022

Hi,
The simplify function here still calls sympy, which is really time consuming.
Since symengine has already implemented its own simplify function.
Could you please update the simplify function as well as add the refine function here accordingly (symengine/symengine#1520).
Thank you very much

@rikardn
Copy link
Contributor

rikardn commented Aug 4, 2022

Thanks for reporting this. Although the refine and simplify are not nearly as mature as the ones in sympy, I think we should use the ones in symengine here. If the user wants to use sympy to simplify that would still be possible, by calling sympy directly. I guess this is legacy from a time when symengine didn't have any similar functionality.

@Goulustis
Copy link

How is the status of this enhancement?

@adrian-kriegel
Copy link

I would also appreciate this. What is currently holding this back? Doesn't the simplify function just need to be added in the wrapper?

@rikardn
Copy link
Contributor

rikardn commented May 6, 2024

Yes, it needs to be added. This also requires the Assumptions class to be added somehow and this might not be as straight forward. Any ideas on how to wrap this for Python?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants