Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Dockerfile for central build #230

Open
RobertGoellinger opened this issue Oct 18, 2023 · 5 comments
Open

Feature: Dockerfile for central build #230

RobertGoellinger opened this issue Oct 18, 2023 · 5 comments

Comments

@RobertGoellinger
Copy link

Thank you so much for this awesome tool!

I have just coded up a little Dockerfile which can be used to run textidote inside the container and host the html in a nginx instance.

This may be an interesting feature for some of you here.

Kind regards,
Robert

@sylvainhalle
Copy link
Owner

Thanks @RobertGoellinger! Would it be ok for you to upload the file into the repository?

@RobertGoellinger
Copy link
Author

Yes absolutely! I tried pushing my proposed changes to a branch on here, but GitHub doesn't want to let me push.
Is there anything I have to keep in mind?

@sylvainhalle
Copy link
Owner

I suggest you open a pull request with your modifications, which I can then merge with the current branch.

@aadityabhatia
Copy link

This is great. Would you consider setting up a GitHub action to automatically publish the docker image? I can create a pull request for it, though I would not be able to create the GitHub token needed to make it work.

@sylvainhalle
Copy link
Owner

Yes, could you please draft the pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants