Light/Dark toggle

[sygmond]

I'm thinking to add a toggle button that toggles light/dark theme.

This would have to be made taking into consideration that later can be added a drop down list with different color themes. In this case, the toggle button will swap the selected color theme to its light/dark negative/opposite color.

[MichelMichels]

Great idea!

But I'm thinking this is a bit out of scope. I'm saying this because the theme of an app is mostly specified by the developer of the application that will be using this code. Most of my WPF apps are written with the MaterialDesignInXaml theme library. If I'd use this library in combination with WindowChromeMultiscreen, I'd like to set the colors/theme depending on what I'm using in my theme library and I'd connect the theme button in the titlebar with the built-in theme switcher of MDIX.

This above reasoning is why I made this issue. When I'm done with this, it will be easy to create multiple default Titlebar controls with different stylings, such as one that you describe in the discussion above.

[sygmond]

Agree. That would give more freedom indeed. Integration with MDIX is something that would be good to add to this or we leave it out of it?

[MichelMichels]

I would try to keep the base of the library as 'clean' as possible to provide the user with a stable library they can built upon. So, I'd not tightly couple it with any style library.

If you'd like to provide such a service out of the box (in this project), I'd let the end-user inject a service that implements an interface we write (like ITitlebarThemeService) that contains functions to change certain features.

Or better yet, provide DependencyProperty values that the end-users can set there colors (mostly Brushes) with some DynamicResource or StaticResource values. But for this, we'll need to abstract the titlebar first in a seperate control.

[sygmond]

I would see this more of a plus for people that don't want to invest any time in styles or they don't have an eye for it and prefer a build in thing, but I'm fully on board with your argument that this would tightly couple things that would cloud the project.